PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Apr 2024

Pull Request for Issue #43242

Summary of Changes

don't process further if no user

Testing Instructions

Create a contact and select a 'Linked User', then delete that user.

Actual result BEFORE applying this Pull Request

error

Expected result AFTER applying this Pull Request

no more errore

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 11 Apr 2024
avatar alikon alikon - change - 11 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2024
Category Front End com_contact
avatar fgsw
fgsw - comment - 11 Apr 2024

PR test successfully but Warning: Undefined property: stdClass::$value in /mnt/data/vhosts/casite-1466051.cloudaccess.net/httpdocs/components/com_contact/tmpl/contact/default_user_custom_fields.php on line 27.

avatar chmst
chmst - comment - 11 Apr 2024

I have tested this item successfully. But it should go into 4.4, as the issue is already in 4.4.

With the PR the user gets this when he opens the contact form and fills the form
grafik

There should be something more informative for a user.

avatar exlemor
exlemor - comment - 11 Apr 2024

on Joomla 5.1 rc2, PHP 8.2.17

I just tried 3 times to create a new user, then create a new contact and link that contact to the new user and then I deleted the user in question and never received an error so therefore I was not able to test this PR for no error message [I have debug and error reporting to maximum].

avatar ellenrothwax
ellenrothwax - comment - 11 Apr 2024

I created a new user, then a new contact and linked that contact to the new user and then I deleted the user in question and never received an error.

avatar SumCompanyInc
SumCompanyInc - comment - 11 Apr 2024

using v5.1 RC1 - i also followed the instructions, "Create a contact and select a 'Linked User', then delete that user." But did not run into any issues deleting the user. going back to the contact, the ID is still listed as the linked user

avatar akshehu akshehu - test_item - 11 Apr 2024 - Tested successfully
avatar akshehu
akshehu - comment - 11 Apr 2024

I have tested this item ✅ successfully on 9979a19

There seem to be no errors present. All good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43254.

avatar alikon
alikon - comment - 11 Apr 2024

@fgsw did you have some custom fields on com_contact ?
@chmst what should looks like as a more informative msg ? and didn't check yet on 4...

strange that others in 5 could not reproduce it

avatar bobbla bobbla - test_item - 11 Apr 2024 - Tested successfully
avatar bobbla
bobbla - comment - 11 Apr 2024

I have tested this item ✅ successfully on 9979a19


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43254.

avatar fgsw
fgsw - comment - 12 Apr 2024

@fgsw did you have some custom fields on com_contact ?

Yes.

strange that others in 5 could not reproduce it

I also could not reproduce an error in first tries until i looked at frontend.

avatar exlemor
exlemor - comment - 12 Apr 2024

Hi @fgsw, I looked at the front end each of the 3 times, I tested this and found no errors [with error reporting to maximum and debug mode on] ;(

avatar fgsw
fgsw - comment - 12 Apr 2024

@exlemor I have only error-reporting set on maximum, but i don't know if this is a real difference. I'm a user, not a developer.

avatar chmst
chmst - comment - 12 Apr 2024

strange that others in 5 could not reproduce it

I think the testers were not aware that the error occurs in frontend, not in backend

As a user I would expect the first message like "[contact_title] This contact is not found in the system. Please contact your system administrator" or something like that - native speaker required. The secind message should not appear at all.

Perhaps the contact form should not be generated if the user is not found

avatar brianteeman
brianteeman - comment - 12 Apr 2024

@fgsw did you have some custom fields on com_contact ? @chmst what should looks like as a more informative msg ? and didn't check yet on 4...

strange that others in 5 could not reproduce it

not strange at all - your testing instructions were extremely vague!!

avatar brianteeman
brianteeman - comment - 12 Apr 2024

Perhaps the contact form should not be generated if the user is not found

That would be the most sensible behaviour. Just the same as when there is no email address in the contact information

avatar fgsw
fgsw - comment - 12 Apr 2024

not strange at all - your testing instructions were extremely vague!!

@brianteeman You're right. In my opinion this happens cause developers think different than a non-developer-tester.

To be honest i had given up to test this pr until i thought "maybe 'frontend' is missing in the instructions".

avatar alikon
alikon - comment - 12 Apr 2024

i apologize

avatar alikon alikon - change - 12 Apr 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-04-12 17:44:08
Closed_By alikon
Labels Added: PR-5.1-dev
avatar alikon alikon - close - 12 Apr 2024

Add a Comment

Login with GitHub to post a comment