RTC Language Change bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
10 Apr 2024

Pull Request for Issue #32419 and related to PR #43250.

Summary of Changes

Add missing language strings for help index and generate toc.json.

Testing Instructions

Open the help index in the backend and check that all help documents are displayed.

grafik

Compare with https://docs.joomla.org/Category:Help_screen_5.0

Actual result BEFORE applying this Pull Request

Entries missing in index / TOC

Expected result AFTER applying this Pull Request

All entries are present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 10 Apr 2024
avatar LadySolveig LadySolveig - change - 10 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2024
Category Administration Language & Strings
avatar LadySolveig
LadySolveig - comment - 10 Apr 2024

I would be grateful for help with the strings and would be very happy to receive a review here @brianteeman

avatar brianteeman
brianteeman - comment - 10 Apr 2024

The strings are auto generated from the wiki so I wouldnt want to change them here as then they would need to be changed on the wiki as well, otherwise your build script will flag them as missing etc each time. So just merge this and be done with it.

(no idea how this works on a non-en-GB site)

avatar brianteeman
brianteeman - comment - 10 Apr 2024

(perhaps my speedy test, review, comments and suggestions on your PR will free up some of your time to respond to my questiopns on my own PR)

avatar brianteeman brianteeman - test_item - 10 Apr 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Apr 2024

I have tested this item ✅ successfully on af07d01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

avatar Kostelano
Kostelano - comment - 10 Apr 2024

Otherwise everything works, I tested it

avatar LadySolveig LadySolveig - change - 10 Apr 2024
Labels Added: Language Change PR-5.1-dev
avatar Kostelano
Kostelano - comment - 11 Apr 2024

@LadySolveig For understanding: will there be a fix for COM_ADMIN_HELP_MENU_ITEM:_SEARCH="Menu Item: Search" or will it remain like this and I can submit a successful test now?

avatar LadySolveig
LadySolveig - comment - 11 Apr 2024

@Kostelano I would like to leave it as it is for now. Would be very happy about a successful test from you!

avatar Kostelano Kostelano - test_item - 11 Apr 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 11 Apr 2024

I have tested this item ✅ successfully on 658ac55


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

avatar exlemor exlemor - test_item - 11 Apr 2024 - Tested successfully
avatar exlemor
exlemor - comment - 11 Apr 2024

I have tested this item ✅ successfully on 658ac55

I was able to test this successfully. Thank you @LadySolveig


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

avatar growunder growunder - test_item - 11 Apr 2024 - Tested successfully
avatar growunder
growunder - comment - 11 Apr 2024

I have tested this item ✅ successfully on 658ac55

Tested successfully and noticed the missing translations, applied patch and it did correted those translations, although there are some missing options in the TOC comparing to the https://docs.joomla.org/Category:Help_screen_5.0 content:

Admin Modules: Logged-in Users
Admin Modules: User Menu
Cache: Clear Cache
Content Security Policy: Reports
Content Security Policy: Options
Information: Database
Information: Warnings
Maintenance: Global Check-in
Menu Item: Category Blog
Menu Item: Category List
Menu Item: Edit User Profile
Menu Item: List All Categories
Menu Item: List All Contact Categories
Menu Item: List All News Feed Categories
Menu Item: List Contacts in a Category
Menu Item: List News Feeds in a Category
Menu Item: User Profile
Menu Item: Username Reminder Request
Pernissions for User
Site Modules: Articles - Categories
Site Modules: Articles - Category
Site Modules: Latest Users
Site Modules: Who's Online
Site Modules: Indexed Content


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.
avatar alikon alikon - change - 11 Apr 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 11 Apr 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43251.

avatar Quy Quy - change - 11 Apr 2024
Labels Added: RTC
avatar bembelimen bembelimen - change - 11 May 2024
Labels Added: bug
avatar bembelimen bembelimen - change - 11 May 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-11 19:10:58
Closed_By bembelimen
avatar bembelimen bembelimen - close - 11 May 2024
avatar bembelimen bembelimen - merge - 11 May 2024
avatar bembelimen
bembelimen - comment - 11 May 2024

Thank you

Add a Comment

Login with GitHub to post a comment