Is it intentional that we only ship the non-minified css for
awesomplete
jquery-minicolors
chosen
or is it a bug in our build scripts?
Labels |
Added:
No Code Attached Yet
|
so why dont we minify them?
Actually I was wrong here, the part that I was referring is about JS:
About the css you're asking:
Although you're right and these files should've both a minified and a non minified version this needs an exception in the tooling. IMO all these packages could/should be dropped instead of patching them here...
keeping them or dropping them is a different discussion. There might be other vendor files that only ship non-minified css in the future
while they are present they should be minified and the tooling needs to be updated to do this.
The debugbar css media/vendor/debugbar/debugbar.css
is not minified, too, and also not gzipped when building a package on the current 5.23-dev branch. In 5.2 beta 2 we had it minified and gzipped. The file provided by debugbar is not minified, so the "yes, these packages do not provide non minified versions" does not apply here.
The gzip works only on .min.[css|js]
all the files from debugbar are .css
or .js
so are skipped
The gzip works only on
.min.[css|js]
all the files from debugbar are.css
or.js
so are skipped
But in 5.2 beta 2 as well as in 4.4 we have a minified file media/vendor/debugbar/debugbar.min.css
and a gzipped file media/vendor/debugbar/debugbar.min.css.gz
, and the original file is also called debugbar.css
.
So it seems something has changed between 5.2 beta 2 and now, and I would call that a regression.
Oh, is that due to changes on the tooling or upstream?
Good question. I have no idea.
Got it: The debugbar css is broken, so npm ci shows an error and doesn't minify it. See https://github.com/maximebf/php-debugbar/releases/tag/v1.23.0 and maximebf/php-debugbar#675 . We just need to update to that version. PR is on the way (but not by me).
pr done
yes, these packages do not provide non minified versions, thus the npm build script has exceptions for those