No Code Attached Yet
avatar brianteeman
brianteeman
9 Apr 2024

Is it intentional that we only ship the non-minified css for
awesomplete
jquery-minicolors
chosen

or is it a bug in our build scripts?

avatar brianteeman brianteeman - open - 9 Apr 2024
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Apr 2024
avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2024

Is it intentional that we only ship the non-minified

yes, these packages do not provide non minified versions, thus the npm build script has exceptions for those

avatar brianteeman
brianteeman - comment - 9 Apr 2024

so why dont we minify them?

avatar dgrammatiko
dgrammatiko - comment - 10 Apr 2024

Actually I was wrong here, the part that I was referring is about JS:

About the css you're asking:

  • awesomplete has a .min.css file that is not really minified
  • jquery minicolors has a non minified file jquery.minicolors.css
  • chosen is abandoned and should have been removed in 5.x

Although you're right and these files should've both a minified and a non minified version this needs an exception in the tooling. IMO all these packages could/should be dropped instead of patching them here...

avatar brianteeman
brianteeman - comment - 10 Apr 2024

keeping them or dropping them is a different discussion. There might be other vendor files that only ship non-minified css in the future

while they are present they should be minified and the tooling needs to be updated to do this.

avatar richard67
richard67 - comment - 12 Sep 2024

The debugbar css media/vendor/debugbar/debugbar.css is not minified, too, and also not gzipped when building a package on the current 5.23-dev branch. In 5.2 beta 2 we had it minified and gzipped. The file provided by debugbar is not minified, so the "yes, these packages do not provide non minified versions" does not apply here.

avatar dgrammatiko
dgrammatiko - comment - 12 Sep 2024

The gzip works only on .min.[css|js] all the files from debugbar are .css or .js so are skipped

avatar richard67
richard67 - comment - 12 Sep 2024

The gzip works only on .min.[css|js] all the files from debugbar are .css or .js so are skipped

But in 5.2 beta 2 as well as in 4.4 we have a minified file media/vendor/debugbar/debugbar.min.css and a gzipped file media/vendor/debugbar/debugbar.min.css.gz, and the original file is also called debugbar.css.

So it seems something has changed between 5.2 beta 2 and now, and I would call that a regression.

avatar dgrammatiko
dgrammatiko - comment - 12 Sep 2024

Oh, is that due to changes on the tooling or upstream?

avatar richard67
richard67 - comment - 12 Sep 2024

Good question. I have no idea.

avatar richard67
richard67 - comment - 12 Sep 2024

Got it: The debugbar css is broken, so npm ci shows an error and doesn't minify it. See https://github.com/maximebf/php-debugbar/releases/tag/v1.23.0 and maximebf/php-debugbar#675 . We just need to update to that version. PR is on the way (but not by me).

avatar brianteeman
brianteeman - comment - 12 Sep 2024

pr done

Add a Comment

Login with GitHub to post a comment