Feature RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
8 Apr 2024

Summary of Changes

Quite some time ago, we introduced code to read the filter state from the filter XML for list views in the backend, making all those setState() code unnecessary. This removes all that unnecessary code.

Testing Instructions

Test if the filters in the list views still work for all the components.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 8 Apr 2024
avatar Hackwar Hackwar - change - 8 Apr 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2024
Category Administration com_associations com_cache com_content com_finder com_installer com_languages com_menus com_modules com_templates com_users
avatar Hackwar Hackwar - change - 8 Apr 2024
Labels Added: PR-5.2-dev
avatar Hackwar Hackwar - change - 29 Apr 2024
Labels Added: Feature
avatar brianteeman brianteeman - test_item - 16 Jul 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Jul 2024

I have tested this item ✅ successfully on 41d68aa

As far as I can tell removing this code has no noticable impact. Tested by checking various filters and by adding the filter to a url.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43230.

avatar fgsw fgsw - test_item - 3 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 3 Aug 2024

I have tested this item ✅ successfully on 41d68aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43230.

avatar Hackwar Hackwar - change - 3 Aug 2024
Status Pending Ready to Commit
avatar pe7er pe7er - change - 8 Aug 2024
Labels Added: RTC
avatar pe7er pe7er - change - 8 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-08 19:19:42
Closed_By pe7er
avatar pe7er pe7er - close - 8 Aug 2024
avatar pe7er pe7er - merge - 8 Aug 2024
avatar pe7er
pe7er - comment - 8 Aug 2024

Thanks @Hackwar !

avatar Quy
Quy - comment - 11 Aug 2024

@Hackwar Go to System > Language Overrides

An error has occurred.

    0 Undefined constant "JPATH_" 

$client = strtoupper($this->getState('filter.client'));

avatar brianteeman
brianteeman - comment - 14 Aug 2024

This needs to be reverted. As well as the language overrides not working any more the update sites check and list of update sites also does NOT work

avatar brianteeman
brianteeman - comment - 14 Aug 2024

To be clear if you clear all site cookies and session data and then log back in then at least these views are empty.
image

avatar brianteeman
brianteeman - comment - 14 Aug 2024

I have created a PR to revert this for now #43918

Add a Comment

Login with GitHub to post a comment