[#43175] - [5.1] Fix SQL syntax error when updating to 5.1 on PostgreSQL
- Fixed in Code Base
- 28 Mar 2024
- Medium
- Build: 5.1-dev
- # 43175
- Diff
- richard67:5.1-dev-fix-guided-tours-update-sql-for-pg
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The update SQL script administrator/components/com_admin/sql/updates/postgresql/5.1.0-2024-03-08.sql introduced with PR #41659 contains 2 syntax errors which cause updating to 5.1 fail with PostgreSQL.
INSERT IGNORE is MySQL/MariaDB syntax which does not work on PostgreSQL. The same thing is already achieved with the ON CONFLICT DO NOTHING at the end of the statement for PostgreSQL.
Testing Instructions
Code review by a PostgreSQL expert, of update to the latest 5.1 nightly build for the actual result, and to the patched package or custom update URL created by Drone for this PR for the expected result, using a PostgreSQL database.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Update succeeds (or at least does not show an SQL error).
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql SQL Administration com_admin |
| Title |
|
||||||
| Labels |
Added:
Release Blocker
bug
PR-5.1-dev
|
||
I have tested this item ✅ successfully on 3b6af99
Tested update from a a beta 1 to a nightly build before which resulted in the error. Update successful with this patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43175.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43175.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-28 19:08:35 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
RTC
|
||
Thank you @richard67 and also for testing @heelc29 @MacJoom
I have tested this item ✅ successfully on 3b6af99
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43175.