Feeling Lucky
Language Change
PR-4.4-dev
[#43173] - [4.4] Postinstallation-Message htaccess.txt brotli change
- Fixed in Code Base
- 28 Mar 2024
- Medium
- Build: 4.4-dev
- # 43173
- Diff
- MacJoom:brotli-htaccess-postinstallation-message
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Postinstallation-Message for Brotli compression bug #43055
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin SQL Postgresql Language & Strings |
| Labels |
Added:
Language Change
PR-4.4-dev
|
||
brianteeman
- comment
- 28 Mar 2024
not sure what will happen when someone who has updated to 4.4.4 then goes to 5.1 - worse case i think is that they will see the message twice
richard67
- comment
- 28 Mar 2024
not sure what will happen when someone who has updated to 4.4.4 then goes to 5.1 - worse case i think is that they will see the message twice
@brianteeman Check my comments in your PR. The message will not be duplicated as we have the INSERT IGNORE/ON CONFLICT DO NOTHING.
brianteeman
- comment
- 28 Mar 2024
which is why I said "not sure" ;)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-28 15:56:51 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 28 Mar 2024
Thanks!
I have tested this item ✅ successfully on e3200de
I've tested updating to the patched package on both MySQL and PostgreSQL. In both cases it worked, and the postinstall message was added.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43173.