RTC Language Change PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Mar 2024

postinstall message for the new brotli compression option.

avatar brianteeman brianteeman - open - 28 Mar 2024
avatar brianteeman brianteeman - change - 28 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2024
Category Administration com_admin SQL Postgresql Language & Strings
d28ca44 28 Mar 2024 avatar brianteeman typos
avatar brianteeman brianteeman - change - 28 Mar 2024
Labels Added: Language Change PR-5.1-dev
avatar MacJoom
MacJoom - comment - 28 Mar 2024

Wow this was fast - thank you Brian!

avatar MacJoom
MacJoom - comment - 28 Mar 2024

we need it for 4.4 too - i can do it

avatar richard67
richard67 - comment - 28 Mar 2024

we need it for 4.4 too - i can do it

@MacJoom But then it still will need the update SQL from this PR here for the case when people update from 5.0.x. The INSERT IGNORE on MySQL/MariaDB and the ON CONFLICT DO NOTHING on PostgreSQL will make sure that the message will not be inserted again when it is already there when people update from 4.4.4 to 5.1.

Your 4.4-dev PR will need new update SQL scripts "4.4.4-2024-03-28.sql" with the same content as the script here (except of the version number in the inserted data).

avatar richard67
richard67 - comment - 28 Mar 2024

I've already tested with success on MySQL. With PostgreSQL the update fails for reasons not related to this PR here, see #43175 . But that delays my test on PostgreSQL for this PR here a bit.

avatar richard67 richard67 - test_item - 28 Mar 2024 - Tested successfully
avatar richard67
richard67 - comment - 28 Mar 2024

I have tested this item ✅ successfully on ea4ca47

I've tested updating to the patched package on both MySQL and PostgreSQL. In both cases it worked, and the postinstall message was added.

For the test with PostgreSQL I had to create a patched package which includes the fix from this PR here as well as the fix from #43175 . Other testers with PostgreSQL can find that package here: https://test5.richard-fath.de/Joomla_5.1.0-beta3-dev+pr.43171-Development-Update_Package__fixed.zip


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171.

avatar richard67 richard67 - alter_testresult - 28 Mar 2024 - richard67: Tested successfully
avatar richard67
richard67 - comment - 28 Mar 2024

I've restored my test result in the tracker since the commits after that were just a branch update with conflicts resolution. I've carefully reviewed the result.

avatar MacJoom MacJoom - test_item - 28 Mar 2024 - Tested successfully
avatar MacJoom
MacJoom - comment - 28 Mar 2024

I have tested this item ✅ successfully on 605e52a

Tested on a server with psql and nginx


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171.
avatar richard67 richard67 - change - 28 Mar 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43171.

avatar LadySolveig LadySolveig - change - 28 Mar 2024
Labels Added: RTC
avatar LadySolveig LadySolveig - change - 28 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-28 19:19:42
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 28 Mar 2024
avatar LadySolveig LadySolveig - merge - 28 Mar 2024
avatar LadySolveig
LadySolveig - comment - 28 Mar 2024

Thank you @brianteeman and for support @richard67 and @MacJoom

Add a Comment

Login with GitHub to post a comment