User tests: Successful: Unsuccessful:
postinstall message for the new brotli compression option.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin SQL Postgresql Language & Strings |
Labels |
Added:
Language Change
PR-5.1-dev
|
we need it for 4.4 too - i can do it
we need it for 4.4 too - i can do it
@MacJoom But then it still will need the update SQL from this PR here for the case when people update from 5.0.x. The INSERT IGNORE
on MySQL/MariaDB and the ON CONFLICT DO NOTHING
on PostgreSQL will make sure that the message will not be inserted again when it is already there when people update from 4.4.4 to 5.1.
Your 4.4-dev PR will need new update SQL scripts "4.4.4-2024-03-28.sql" with the same content as the script here (except of the version number in the inserted data).
I have tested this item ✅ successfully on ea4ca47
I've tested updating to the patched package on both MySQL and PostgreSQL. In both cases it worked, and the postinstall message was added.
For the test with PostgreSQL I had to create a patched package which includes the fix from this PR here as well as the fix from #43175 . Other testers with PostgreSQL can find that package here: https://test5.richard-fath.de/Joomla_5.1.0-beta3-dev+pr.43171-Development-Update_Package__fixed.zip
I've restored my test result in the tracker since the commits after that were just a branch update with conflicts resolution. I've carefully reviewed the result.
I have tested this item ✅ successfully on 605e52a
Tested on a server with psql and nginx
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-28 19:19:42 |
Closed_By | ⇒ | LadySolveig |
Thank you @brianteeman and for support @richard67 and @MacJoom
Wow this was fast - thank you Brian!