No Code Attached Yet bug
avatar heelc29
heelc29
25 Mar 2024

Steps to reproduce the issue

open administration and visit dashboard (debug enabled)

Expected result

Only 1 additional database query to check if autostart necessary

  • when yes: then load all data (translation, steps, ...)
  • when no: don't load additional stuff

Actual result

38 database queries (4 additional after autostart feature)
image

warning about untranslated strings (only visible in debug bar, because they are not necessary to load)
image

avatar heelc29 heelc29 - open - 25 Mar 2024
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Mar 2024
avatar brianteeman
brianteeman - comment - 26 Mar 2024

Confirmed. Didnt dig into the queries but there is no reason for the language strings to be loaded if the guided tour has been disabled

avatar Quy Quy - change - 26 Mar 2024
Labels Added: bug
avatar Quy Quy - labeled - 26 Mar 2024
avatar obuisard
obuisard - comment - 27 Mar 2024

In the TourModel.php, I propose we have an extra function called isAutostart() that does a simple query without using getTour() which does the extra work for nothing if the autostart is set to 0.

avatar obuisard obuisard - change - 27 Mar 2024
Status New Closed
Closed_Date 0000-00-00 00:00:00 2024-03-27 19:04:53
Closed_By obuisard
avatar obuisard obuisard - close - 27 Mar 2024

Add a Comment

Login with GitHub to post a comment