[#43147] - [5.1] Merge update parameter and improve contrain checker
- Fixed in Code Base
- 27 Mar 2024
- Medium
- Build: 5.1-dev
- # 43147
- Diff
- bembelimen:tuf/update-fixes
User tests: Successful: Unsuccessful:
Pull Request for Issue #43100 .
Summary of Changes
With TUF testing channel is not needed anymore and should use the TUF behaviour. Also allow now explicit testing for "default" and "next"
Testing Instructions
- Install Beta 1
- Apply patch to beta 1
- Go to joomla updater
- Go to options and select "default" + "beta" for stability level
- Update
Actual result BEFORE applying this Pull Request
Options not there, update does not work
Expected result AFTER applying this Pull Request
Update works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Libraries |
| Labels |
Added:
PR-5.1-dev
|
||
I have tested this item ✅ successfully on ea1b3fb
From a 5.1 Beta 1 Installation. Without the patch i have the message 'This site can't be updated to Joomla 5.1.0-beta2 .... doesn't meet the minimum requirements...' - with the patch it works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.
I have tested this item ✅ successfully on ea1b3fb
Same behavior as described by @MacJoom
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.
| Status | Pending | ⇒ | Ready to Commit |
RTC as this PR has 2 successful human tests. But it needs more fixes for the updater when using TUF. E.g. the channel ("5.x" or "6.x" depending on Default or Next update source) currently is currently not checked, as far as I can see, and there is one more place where we should use the minimumStability parameter independently from the selected update channel as suggested with my PR for this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.
I have tested both "default" and "next" channel. With the patch it works as expected for both channels. It gives different messages depending on the channel set. "next" channel offers the update to 5.1 beta 2.
| Labels |
Added:
RTC
|
||
| Category | Administration com_joomlaupdate Libraries | ⇒ | Administration com_joomlaupdate Language & Strings Libraries |
| Labels |
Added:
Language Change
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-27 19:55:40 |
| Closed_By | ⇒ | LadySolveig |
Thank you @bembelimen and for support to @richard67 and also for testing @MacJoom and @dautrich
Should the code comments here be updated to include "testing"
joomla-cms/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
Line 107 in ea1b3fb