[#43135] - [5.1] Cog icon focus [a11y]
- Fixed in Code Base
- 29 Mar 2024
- Medium
- Build: 5.1-dev
- # 43135
- Diff
- brianteeman:focus
User tests: Successful: Unsuccessful:
adds an outline to the cog when it receives keyboard focus
Pull Request for Issue #43066 .
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on 9bcda96
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43135.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43135.
| Labels |
Added:
RTC
a11y
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-29 23:04:47 |
| Closed_By | ⇒ | wilsonge |
Thanks!
This PR is not optimal, because the selector is too generic. Now all buttons in the cpanel which are the first child get this effect. It should be either reverted or fixed (by being more specific).
can you provide an example please so I can check
From what I can see the only button that can ever match the selector is the cog - what am I missing?
It selected every item with the class "btn" which is the first child. So if a module has a btn, it gets the styling, too.
My concern is that a second button (for a custom module) does not get the focus-ring
It selected every item with the class "btn" which is the first child. So if a module has a btn, it gets the styling, too.
demonstrably not true, otherwise the buttons in the sample data module would have the outline
My concern is that a second button (for a custom module) does not get the focus-ring
Please show an example
I have tested this item ✅ successfully on 9bcda96
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43135.