Updates Requested NPM Resource Changed bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
24 Mar 2024

Pull Request for Issue #42653 .

Summary of Changes

In the linked issue, the user complained that the rtl stylesheet is missing from our media folder. This PR adds that file. I'm not sure if it is necessary, but here it is.

Testing Instructions

Run npm i in your git checkout.

Actual result BEFORE applying this Pull Request

There is neither a media/vendor/bootstrap/css/bootstrap.rtl.css nor a media/vendor/bootstrap/css/bootstrap.rtl.min.css file present.

Expected result AFTER applying this Pull Request

The two above files have been generated.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 24 Mar 2024
avatar Hackwar Hackwar - change - 24 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2024
Category Repository
avatar brianteeman
brianteeman - comment - 2 Apr 2024

Unfortunately this is not enough. You woudl also need to add the rtl variants of the other files and the complete set of files for bootstrap-utilities.

avatar Hackwar
Hackwar - comment - 22 Nov 2024

I'm closing this PR, since it indeed would require more than this small change.

avatar Hackwar Hackwar - change - 22 Nov 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-11-22 20:27:46
Closed_By Hackwar
Labels Added: Updates Requested NPM Resource Changed bug PR-5.2-dev
avatar Hackwar Hackwar - close - 22 Nov 2024

Add a Comment

Login with GitHub to post a comment