[#43123] - [5.1] language code rich snippet revert
- Fixed in Code Base
- 11 Apr 2024
- Medium
- Build: 5.0-dev
- # 43123
- Diff
- brianteeman:patch-3
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
In the large Rich Snippets PR #41151 a line was changed that has resulted in invalid markup and broken functionality of the language code plugin
Testing Instructions
-
Create an article in and view the article in the front end.
Check the source and you will see the invalid markup
<meta content="en-GB"> -
open the language code plugin, enable and save
go to the new tab in that plugin and change the lanbguage code to en-BT
Refresh the front and refresh the page. View the source and you will see the same invalid markup as in test 1 -
Apply the one line change in this PR
Disable the language code plugin
Refresh the front and refresh the page. View the source and you will see the<meta itemprop="inLanguage" content="en-GB">
This is the correct and valid markup -
Re-enable the language code plugin and check the frone end again and you will see
<meta itemprop="inLanguage" content="en-BT">
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item ✅ successfully on e371631
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43123.
Thank you for this contribution. I would really like to merge this in 5.1 if you would find the time to rebase @brianteeman
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
PR-5.1-dev
|
||
rebased to 5.1 as requested
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-11 00:53:56 |
| Closed_By | ⇒ | bembelimen |
Thx
I thought the idea in J5 was to remove itemprops from the template php files and let Joomla's schema.org add the correct code. Now, on updating from 5.0.3 to 5.1.0 I see that itemprop="inLanguage" has appeared in html/com_content/article/default.php. Is that right?
I have tested this item ✅ successfully on e371631
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43123.