RTC bug PR-5.0-dev PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
22 Mar 2024

Pull Request for Issue #43113 .

Summary of Changes

Added an alias for 'js' so that CodeMirror understands what language package to load.

Testing Instructions

See issue #43113

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar OctavianC OctavianC - open - 22 Mar 2024
avatar OctavianC OctavianC - change - 22 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2024
Category Front End Plugins
avatar Fedik Fedik - test_item - 22 Mar 2024 - Tested successfully
avatar Fedik
Fedik - comment - 22 Mar 2024

I have tested this item ✅ successfully on d54448f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

avatar viocassel viocassel - test_item - 22 Mar 2024 - Tested successfully
avatar viocassel
viocassel - comment - 22 Mar 2024

I have tested this item ✅ successfully on d54448f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

avatar alikon alikon - change - 22 Mar 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 22 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

avatar Linkedla
Linkedla - comment - 11 Apr 2024

image

It is working after applying the patch.
Applied Commit SHA: d54448f

avatar brianteeman
brianteeman - comment - 11 Apr 2024

Thank you for testing - please go to https://issues.joomla.org/tracker/joomla-cms/43114 and record your test there

avatar Linkedla Linkedla - test_item - 11 Apr 2024 - Tested successfully
avatar Linkedla
Linkedla - comment - 11 Apr 2024

I have tested this item ✅ successfully on d54448f

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43114.

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.1-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
CodeMirror 6 Javascript highlighting not working
[5.1] CodeMirror 6 Javascript highlighting not working
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar LadySolveig LadySolveig - change - 11 May 2024
Labels Added: RTC bug PR-5.0-dev PR-5.1-dev
avatar LadySolveig
LadySolveig - comment - 11 May 2024

Thank you @OctavianC and for the tests @Fedik @viocassel and @Linkedla !

avatar LadySolveig LadySolveig - close - 11 May 2024
avatar LadySolveig LadySolveig - merge - 11 May 2024
avatar LadySolveig LadySolveig - change - 11 May 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-05-11 18:22:35
Closed_By LadySolveig

Add a Comment

Login with GitHub to post a comment