[#43112] - [5.1] toolbar button wrap
- Closed
- 23 Mar 2024
- Medium
- Build: 5.1-dev
- # 43112
- Diff
- brianteeman:toolbar
User tests: Successful: Unsuccessful:
Pull Request for Issue #43030 .
Summary of Changes
By changing the margin to after (inline-end) it is possible to align the buttons correctly when the button row collapses
Testing Instructions
As this is a scss change ether use a pre-built package or npm run build:css
Go to a page with a lot of toolbar buttons such as the extensions manage page and resize your browser window until the row of buttons wraps onto a second row
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-22 09:21:12 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-03-22 09:21:12 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Pending |
Thanks @brianteeman and others who worked on this and fixed it.
No longer right-aligned.
Almost there ... in mobile view.
I have tested this item ✅ successfully on e978e5e
Thank you!!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43112.
I have tested this item ✅ successfully on e978e5e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43112.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43112.
do not merge yet. spotted some more edge cases to fix.
| Status | Ready to Commit | ⇒ | Pending |
I am closing this. Too many edge cases being created with this changed approach.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-23 17:03:32 |
| Closed_By | ⇒ | brianteeman |
~Thanks @C-Lodder ~ sorry wrong issue