[#43093] - [5.1] Finder: Allow finder plugins to output spaces
- Fixed in Code Base
- 27 Mar 2024
- Medium
- Build: 5.1-dev
- # 43093
- Diff
- Hackwar:5.1-finder-trim
User tests: Successful: Unsuccessful:
Pull Request for Issue #43000 .
Summary of Changes
Finder plugins should not generate any output when being run. If they create output, we expect this to be the output of notices, errors or warnings from PHP directly. This check has been added in 5.0, however some finder plugins out there seem to generate output, most likely from switching between PHP and HTML context. This PR makes this a bit less strict by allowing spaces and new line characters as output. I consider this an acceptable compromise.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
I have tested this item ✅ successfully on af165ba
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-22 10:57:01 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
RTC
bug
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-03-22 10:57:01 | ⇒ | |
| Closed_By | Hackwar | ⇒ | |
| Labels |
Removed:
RTC
|
||
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.
For anyone stumbling on this before 5.1 is released. These were the symptoms that lead me to this fix in my case:
- The useful message
A "finder" plugin has had an error.ineverything.phplog. - The error
Error An error has occurred while fetching the JSON data: HTTP 502 status code. Bad gateway.in the Smart Search Indexer modal.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-27 18:02:38 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
Thx
I have tested this item ✅ successfully on af165ba
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43093.