[#43091] - [5.2] Finder: Simplifying the populateState() method of SearchModel
- Fixed in Code Base
- 14 Aug 2024
- Medium
- Build: 5.1-dev
- # 43091
- Diff
- Hackwar:5.1-finder-input
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43087 .
Summary of Changes
For reasons unobvious to me, we are using the data from the request object in our input object when populating the state of the SearchModel model. This PR changes this to be in line with all other models by simply using the input object.
Testing Instructions
Codereview?
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
LadySolveig
- | Title |
|
||||||
| Labels |
Added:
Feature
PR-5.2-dev
|
||
I would expect the reason is that you can simple use POST or GET requests for the search, now only GET is possible anymore?
now only GET is possible anymore?
Nope, it the same, $input contain whole data from $_REQUEST, so it will be same result as $input->request.
For only GET would be $input->get->get('foobar'),
For only POST would be $input->post->get('foobar'),
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-14 10:11:52 |
| Closed_By | ⇒ | laoneo |
Thanks!
Code reviewed, seams ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43091.