[#43074] - [5.1] Trailing Slash: Don't remove slash when it's the only path char
- Fixed in Code Base
- 18 Mar 2024
- Medium
- Build: 5.1-dev
- # 43074
- Diff
- Hackwar:5.1-router-trailing3
User tests: Successful: Unsuccessful:
Pull Request for Issue #43069.
Summary of Changes
When the site runs in the root of the domain and the path is empty, because the URL is entirely query parameters, the slash to make the URL relative to the root folder is removed, resulting in the URL becoming relative to the current URL. This PR makes an exception for this special case.
Testing Instructions
- In the System - SEF plugin set to remove trailing slash.
- Create an article in the uncategorised category.
- Click on the Preview button.
Actual result BEFORE applying this Pull Request
Either no modal is displayed or an error page is shown instead. (When the article is alternatively the homepage, the URL is completely empty, resulting in a JS error.)
Expected result AFTER applying this Pull Request
The preview is properly displayed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item ✅ successfully on 9948625
I've replicated the issue as described in #43069 and tested the patch in various scenarios:
- Non-Multilanguage site without sef in domain root
- Non-Multilanguage site with sef in domain root
- Multilanguage site in with sef domain root
- Multilanguage site in without sef domain root
- Non-Multilanguage site without sef in subdirectory
- Non-Multilanguage site with sef in subdirectory
- Multilanguage site in with sef in subdirectory
- Multilanguage site in without sef in subdirectory
The patch worked in all scenarios.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43074.
I have tested this item ✅ successfully on 9948625
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43074.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43074.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-18 20:18:53 |
| Closed_By | ⇒ | LadySolveig |
Thank you @Hackwar and also for testing and review @SniperSister @viocassel
These test instructions are not enough to replicate the problem and therefore test the fix