[#4307] - Use new JTable features for WeblinksTableWeblink
- Closed
- 8 Oct 2014
- Medium
- Build: 3.4-dev
- Easy Test
- # 4307
- Diff
- wilsonge:patch-25
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This method removes the overridden method for the publish method in favour of the table column alias introduced in #3416
It also removes the override for the bind method in favour of the quicker method introduced in #3423
Testing
Test publishing a weblink in the list view works as expected (single and multiple items) and that saving an item works correctly (with things like associated images, params and metadata)
jissues-bot
- | Labels |
Added:
?
|
||
@test looks ok here publishing weblinks and saving weblinks still works after the patch is applyed
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Category | ⇒ | Administration Code style Components |
| Easy | No | ⇒ | Yes |
@test ok! Good job ;)
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@test ok! Good job ;)
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
Oops, sry for double comment :)
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Status | Pending | ⇒ | Ready to Commit |
thanks @b2z moving RTC
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
| Labels |
Added:
?
|
||
As weblinks does not exist anymore we can't merge this into 3.4-dev
Can you to send this against: https://github.com/joomla-extensions/weblinks ?
I'm closing this.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-08 07:28:45 |
| Labels |
Removed:
?
|
||
This also fixes a load of code style things. Because the code no longer exists to error