No Code Attached Yet a11y bug Dark Mode
avatar C-Lodder
C-Lodder
17 Mar 2024

Steps to reproduce the issue

The "Please fill in this field" do not meet the color contrast requirements in dark mode

I suppose this isn't just relevant to the form field, but all form validation.

Screenshot

image

avatar C-Lodder C-Lodder - open - 17 Mar 2024
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2024
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Mar 2024
avatar C-Lodder C-Lodder - change - 17 Mar 2024
The description was changed
avatar C-Lodder C-Lodder - edited - 17 Mar 2024
avatar chmst chmst - change - 17 Mar 2024
Labels Added: a11y bug Dark Mode
avatar chmst chmst - labeled - 17 Mar 2024
avatar chmst chmst - labeled - 17 Mar 2024
avatar chmst chmst - labeled - 17 Mar 2024
avatar brianteeman
brianteeman - comment - 17 Mar 2024

it is an easy fix but I dont understand why it has been created in the way it has been done so am reluctant to make an arbitrary change that may have consequences

The relevant code is in build\media_source\templates\administrator\atum\scss\_variables-dark.scss
$danger-dark: #c62a25; // contrast ratio: 5.59 with #fff text

avatar brianteeman
brianteeman - comment - 17 Mar 2024
avatar coolcat-creations
coolcat-creations - comment - 17 Mar 2024

Will look into it. Unfortunately I also don't know why some things were done like they were done. Would be a good thing to refactor one day.

avatar brianteeman
brianteeman - comment - 3 Apr 2024

My comment above was incorrect.

This error text is generated by the browser and can not be styled

avatar coolcat-creations
coolcat-creations - comment - 4 Apr 2024

I will try to find a fix, sorry did not have the time yet

Add a Comment

Login with GitHub to post a comment