Feeling Lucky
RTC
bug
PR-4.4-dev
[#43053] - [4.4] Fix finder helper addContentType duplicate entry for key 'title'
- Fixed in Code Base
- 20 May 2024
- Medium
- Build: 4.4-dev
- # 43053
- Diff
- Fedik:finder-fix-duplicatekey2
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When Finder helper trying to add a new content type it ignores already added types.
This leads to duplicated entry error.
Testing Instructions
Run following code anywhere:
$name = uniqid(); // Imitating a new content type name, can be any string
var_dump(Joomla\Component\Finder\Administrator\Indexer\Helper::addContentType($name, ''));
var_dump(Joomla\Component\Finder\Administrator\Indexer\Helper::addContentType($name, ''));Actual result BEFORE applying this Pull Request
An error Duplicate entry 'xxxxx' for key 'xxxx.title'
Expected result AFTER applying this Pull Request
No error, the method return the same ID
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
bug
PR-4.4-dev
|
||
HLeithner
- | Title |
|
||||||
viocassel
- comment
- 17 May 2024
I have tested this item ✅ successfully on 7b1dfd4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43053.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 18 May 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43053.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-20 21:11:43 |
| Closed_By | ⇒ | MacJoom |
I have tested this item ✅ successfully on 7b1dfd4
@Fedik, I have successfully tested this in Joomla 4.4.4 (as well as Joomla 5.1.0 as well)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43053.