[#43031] - [5.1] Update TourTable.php to allow save on tours
- Fixed in Code Base
- 17 Mar 2024
- Medium
- Build: 5.1-dev
- # 43031
- Diff
- obuisard:guided-tours-save
User tests: Successful: Unsuccessful:
Summary of Changes
Since the introduction of the welcome tour, the addition of the autostart column fails the saving of tours.
Testing Instructions
Go to System -> Guided Tours, create a tour and save.
Try also 'duplicate' and 'save as copy'.
Actual result BEFORE applying this Pull Request
Error 'Save failed with the following error: Column 'autostart' cannot be null'.
Expected result AFTER applying this Pull Request
No error on save.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Title |
|
||||||
would it not be better to update the sql instead?
The database already defaults autostart to 0.
At this point, the autostart is not present as an option to the user. Once we have the full functionality (we will make auto-start as an option to the tour in the form), we can remove that additional test.
yes but you could also set it to allow null couldnt you and then you dont need this temporary code?
yes but you could also set it to allow null couldnt you and then you dont need this temporary code?
Oh I see what you mean... It felt 'safer' this way so I don't mess with the database again and add extra files.
I have tested this item ✅ successfully on cf6cbc2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031.
| Labels |
Added:
PR-5.1-dev
|
||
| Labels |
Added:
bug
|
||
I have tested this item ✅ successfully on 1bef0eb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031.
I have tested this item ✅ successfully on 1bef0eb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43031.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-17 11:56:48 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
Thx
would it not be better to update the sql instead?