Feeling Lucky
RTC
NPM Resource Changed
bug
PR-5.1-dev
Dark Mode
[#43018] - [5.1] DARK MODE installer drag and drop
- Fixed in Code Base
- 14 Mar 2024
- Medium
- Build: 5.1-dev
- # 43018
- Diff
- brianteeman:drag_drop
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
add css and change to [data-bs-theme-dark]
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
PR-5.1-dev
|
||
brianteeman
- comment
- 13 Mar 2024
i would but it doesnt work
Fedik
- comment
- 13 Mar 2024
Okay then :)
brianteeman
- comment
- 13 Mar 2024
maybe it was me and someone else can get it to work
Fedik
- comment
- 14 Mar 2024
@brianteeman I made a quick check and data-color-scheme works to me:
[data-color-scheme=dark] #dragarea.hover #upload-icon,
[data-color-scheme=dark] #dragarea p.lead {
color: #eee;
}
[data-color-scheme=dark] #dragarea.hover {
background-color: #666;
border-color: #eee;
}
brianteeman
- comment
- 14 Mar 2024
I will take another look. Probably did something daft
| Labels |
Added:
bug
Dark Mode
|
||
Fedik
- comment
- 14 Mar 2024
I have tested this item ✅ successfully on 9d48656
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43018.
Quy
- comment
- 14 Mar 2024
I have tested this item ✅ successfully on 9d48656
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43018.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 14 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43018.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-14 17:22:19 |
| Closed_By | ⇒ | LadySolveig |
I think use of
data-color-schemewould be preferable, in non BS files.