[#43002] - [5.1] - Fix JHTTP socket transport http version
- Fixed in Code Base
- 11 Mar 2024
- Medium
- Build: 5.1-dev
- # 43002
- Diff
- SniperSister:5.1-jhttp-socketdriver-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #38963 and #42973
Summary of Changes
In #35568 a change was merged into the JHTTP socket driver, increasing the accepted HTTP version for the client from 1.0 to 1.1.
That change introduce the issue described in #38963: HTTP 1.1 defines the chunked transfer mode which is mandatory for all clients implementing HTTP 1.1 - as our socket-based client however does not support chunked responses, a chunked response causes an infinite loop.
Testing Instructions
- Create a socket-based JHTTP request to a server responding with a chunked response, i.e. by using this code block:
$http = \Joomla\CMS\Http\HttpFactory::getHttp([], 'socket'); $response = $http->get('https://update.joomla.org/cms/root.json');
Actual result BEFORE applying this Pull Request
- Infinite loop
Expected result AFTER applying this Pull Request
- Response returned
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
richard67
- | Labels |
Added:
Release Blocker
PR-5.1-dev
|
||
still
when no curl
no luck
it's my faulty settings or ?
| Category | Libraries | ⇒ | External Library Composer Change Libraries |
| Labels |
Added:
Composer Dependency Changed
|
||
... or without TUF by executing the code snippet mentioned in the test instructions :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-11 20:32:55 |
| Closed_By | ⇒ | LadySolveig |
Thanks
I have tested this item ✅ successfully on f54a18f
Works now
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43002.