?

User tests: Successful: Unsuccessful:

avatar shur
shur
18 Sep 2014

If you export a live site's database and compare it to the core joomla.sql you'll see lots of minor differences. This hardens the database examination and shows that joomla.sql contains many code style mistakes.

What I did:

  • Removed the spacing errors;
  • Names for all variables are now of the same case.
  • Database tables are now listed in alphabetical order; <<< changes removed

The last issue caused most of problems, because the tables arrangement in the original joomla.sql is not alphabetical. Many of the tables are listed almost randomly, which makes it difficult to compare your site database with the original joomla.sql.

How to test:
To make sure that my changes are correct you can do the following:

1) Get an empty database;
Import the original joomla.sql file;
Export the current database to the file e.g. joomla-var1.sql

2) Drop all tables in the database;
Import my joomla.sql file;
Export the current database to the file e.g. joomla-var2.sql

3) Compare joomla-var1.sql and joomla-var2.sql - there shouldn't any differences between them.

avatar shur shur - open - 18 Sep 2014
avatar jissues-bot jissues-bot - change - 18 Sep 2014
Labels Added: ?
avatar shur shur - change - 18 Sep 2014
Title
Code style changes for Joomla 2.5 SQL file
[Code Style] changes for Joomla 2.5 SQL file
avatar shur shur - change - 18 Sep 2014
The description was changed
avatar zero-24 zero-24 - change - 19 Sep 2014
Category Code style
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar shur
shur - comment - 7 Dec 2014

Updated to Joomla! 2.5.28 RC

Database tables are now listed in alphabetical order;

These changes have been removed to facilitate PR

avatar shur shur - change - 10 Dec 2014
The description was changed
avatar brianteeman brianteeman - change - 1 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-01 13:01:33
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 1 Jan 2015

Thanks for working on this. Unfortunately this did not make it into the final release of Joomla 2.5, or it was handled elsewhere, so this is being closed. If you feel this is still a valid issue in Joomla 3 please create a new issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4300.

avatar brianteeman brianteeman - close - 1 Jan 2015
avatar brianteeman brianteeman - close - 1 Jan 2015
avatar brianteeman brianteeman - change - 1 Jan 2015
Closed_Date 2015-01-01 13:01:33 2015-01-01 13:01:34
avatar shur shur - head_ref_deleted - 3 Jul 2015

Add a Comment

Login with GitHub to post a comment