[#42995] - [5.1] Alert links system container [a11y]
- Fixed in Code Base
- 18 Mar 2024
- Medium
- Build: 5.1-dev
- # 42995
- Diff
- brianteeman:alert_link
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42986 (comment) .
Summary of Changes
Adds the alert-link class to the string
Removes the color attribute on the link as it was overriding the specific classes for each type of alert
Testing Instructions
You must be testing this with the latest branch!!
Go to System->Update sites and disable any update site
Go to System->Updates and check for updates
Actual result BEFORE applying this Pull Request
Light Mode
Dark Mode
Expected result AFTER applying this Pull Request
Light Mode
Dark Mode
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Repository NPM Change |
ok, its confirmed my commit was removed because it did not work so well ;-) I will test yours now
Contrast Issue:
In light mode, only the success link looks wrong
Thanks @brianteeman for fixing, I broke that thing and missed it (was too late). So will put it in the 5.1.0 milestone, it should be fir sure merged.
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.1-dev
|
||
I can see the link change from plain to underlined. But I see a different colour scheme. I am using a cms clone and did git pull then npm ci; the Status bar shows 5.1.0-beta2-dev; and I use the Firefox Dark/Light mode switcher (on Mac OS). The backgrounds are all (nearly) black. What am I doing wrong?
I can see the link change from plain to underlined. But I see a different colour scheme. I am using a cms clone and did git pull then npm ci; the Status bar shows 5.1.0-beta2-dev; and I use the Firefox Dark/Light mode switcher (on Mac OS). The backgrounds are all (nearly) black. What am I doing wrong?
best thing is if you download a package here in this PR and install this
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-18 22:07:44 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
a11y
bug
Dark Mode
|
||
Thank you @brianteeman
thats strange, thats actually one of my last commits / fixes yesterday into the Main PR... Did it went lost?