On a current 5.1-dev branch or a 5.1.0.-beta1, change the update channel in the Joomla Update component's options to "Custom URL" and enter the custom update URL created by drone for some current 5.1-dev PR. E.g. for PR #42992 use https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42992/downloads/74472/pr_list.xml .
Result: An update to the patched package for that PR is found.
Try to update.
Live update with a custom update URL for a pull request works.
Joomla 5.1.0-beta1 or current 5.1-dev branch or nightly build which include the TUF implementation from PR #42799 .
Upload & Update with pull request packages works as before the TUF PR, only Live Update has that problem.
No idea why I haven't noticed that when testing PR #42799 .
The error message comes from a new version check implemented with PR #42799 here:
// The versions mismatch
if ($result['version'] !== $this->input->get('targetVersion')) {
$message = Text::_('COM_JOOMLAUPDATE_VIEW_UPDATE_VERSION_WRONG');
$messageType = 'error';
$url = 'index.php?option=com_joomlaupdate';
$this->app->setUserState('com_joomlaupdate.file', null);
$this->setRedirect($url, $message, $messageType);
Log::add($message, Log::ERROR, 'Update');
return;
}
Some debug output which I've added shows that $result['version']
is 5.1.0-beta2-dev+pr.42992
and $this->input->get('targetVersion')
is 5.1.0-beta2-devpr.42992
, so the latter is missing the +
between the dev
and the pr
.
Labels |
Added:
No Code Attached Yet
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-10 11:19:21 |
Closed_By | ⇒ | richard67 |
I think I know how to fix it. It just needs the "sting" filter for the
input->get
.