RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomlaweby
joomlaweby
9 Mar 2024

Summary of Changes

Converts the administrator login module to service provider.

Testing Instructions

  1. You should see module output in administrator login page

mod_login

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomlaweby joomlaweby - open - 9 Mar 2024
avatar joomlaweby joomlaweby - change - 9 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2024
Category Modules Administration
avatar ceford ceford - test_item - 11 Mar 2024 - Tested successfully
avatar ceford
ceford - comment - 11 Mar 2024

I have tested this item ✅ successfully on 1ac8a37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42990.

avatar viocassel viocassel - test_item - 11 Mar 2024 - Tested successfully
avatar viocassel
viocassel - comment - 11 Mar 2024

I have tested this item ✅ successfully on 1ac8a37


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42990.

avatar richard67 richard67 - change - 11 Mar 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Mar 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42990.

avatar joomlaweby joomlaweby - change - 11 Mar 2024
Labels Added: RTC PR-5.1-dev
avatar richard67
richard67 - comment - 11 Mar 2024

RTC is still valid as the change after that was just small code style change.

avatar LadySolveig
LadySolveig - comment - 13 Mar 2024

Thank you @joomlaweby ? and also for testing and review @ceford @viocassel @sandewt

avatar LadySolveig LadySolveig - change - 13 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-13 18:33:35
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 13 Mar 2024
avatar LadySolveig LadySolveig - merge - 13 Mar 2024

Add a Comment

Login with GitHub to post a comment