Feeling Lucky
RTC
PR-5.1-dev
[#42972] - [5.1] Typehint false for getItem
- Fixed in Code Base
- 17 Mar 2024
- Medium
- Build: 5.1-dev
- # 42972
- Diff
- Digital-Peak:getitem/return
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
To improve compatibility with PHP type checking tools like PHPStan, we need to narrow the boolean return type, as a boolean is only returned as false.
Code review only.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
PR-5.1-dev
|
||
viocassel
- comment
- 8 Mar 2024
I have tested this item ✅ successfully on a4a5435
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42972.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 8 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42972.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-17 15:07:35 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
bembelimen
- comment
- 17 Mar 2024
Thx
I have tested this item ✅ successfully on a4a5435
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42972.