[#42967] - [5.1] Remove unused use statements to fix PHPCS
- Closed
- 5 Mar 2024
- Medium
- Build: 5.1-dev
- # 42967
- Diff
- richard67:5.1-dev-fix-phpcs-2024-03-05
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Currently the PHPCS step is failing in Drone in the 5.1-dev branch because php-cs-fixer finds an unused use statement, see drone logs https://ci.joomla.org/joomla/joomla-cms/74369/1/7 and https://ci.joomla.org/joomla/joomla-cms/74368/1/7 of the last 2 commits in the 5.1-dev branch.
Testing Instructions
Check if the PHPCS step succeeds in drone for this PR and for the last commit in the 5.1-dev branch.
Or instead of checking Drone logs, run php-cs-fixer locally on the current 5.1-dev branch and on the branch of this PR.
Actual result BEFORE applying this Pull Request
The php-cs-fixer fails the 5.1-dev branch.
Expected result AFTER applying this Pull Request
The php-cs-fixer succeeds for this PR.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Title |
|
||||||
I have tested this item ✅ successfully on ab74ae4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42967.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
Unit/System Tests
|
||
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42967.
bembelimen
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-05 18:00:40 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on ab74ae4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42967.