Feature b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
5 Mar 2024

Summary of Changes

Followup of #42717, to return a \stdClass instead of CMSObject in the Adminmodel getItem function. Developers should work directly on the properties on the returned item and not call the deprecated set or get function.

Testing Instructions

  • Install 3rd party content plugins
  • Create an article
  • Open the article on the front end

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#237

  • No documentation changes for manual.joomla.org needed

avatar laoneo laoneo - open - 5 Mar 2024
avatar laoneo laoneo - change - 5 Mar 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2024
Category Administration com_banners com_categories com_contact com_content com_fields com_modules com_newsfeeds com_users Libraries
avatar laoneo laoneo - change - 8 Mar 2024
Labels Added: b/c break PR-6.0-dev
avatar laoneo laoneo - change - 15 Mar 2024
The description was changed
avatar laoneo laoneo - edited - 15 Mar 2024
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
The admin model does return a stdClass instead of CMSObject
[6.0] The admin model does return a stdClass instead of CMSObject
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar laoneo laoneo - change - 4 Dec 2024
Labels Added: Feature Updates Requested
avatar Bodge-IT
Bodge-IT - comment - 7 Dec 2024

@laoneo what's needed to get these checks cleared?

avatar Bodge-IT Bodge-IT - test_item - 7 Dec 2024 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 7 Dec 2024

I have tested this item ✅ successfully on 1b7bbd7

Worked in both states


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42961.

avatar laoneo laoneo - change - 7 Dec 2024
Labels Removed: Updates Requested
avatar laoneo
laoneo - comment - 7 Dec 2024

Fixed the deprecated bug in the task model.

avatar Bodge-IT Bodge-IT - test_item - 7 Dec 2024 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 7 Dec 2024

I have tested this item ✅ successfully on d1a1bba

Content plugin worked on unpatched and patched states


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42961.

avatar softforge softforge - test_item - 7 Dec 2024 - Tested successfully
avatar softforge
softforge - comment - 7 Dec 2024

I have tested this item ✅ successfully on d1a1bba

I have tested this successfully but we will need an entry in the manual once 6.0 has been added to the manual


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42961.

avatar laoneo
laoneo - comment - 7 Dec 2024

Made a pr already joomla/Manual#237.

avatar Bodge-IT Bodge-IT - close - 7 Dec 2024
avatar Bodge-IT Bodge-IT - merge - 7 Dec 2024
avatar Bodge-IT Bodge-IT - change - 7 Dec 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-12-07 16:14:07
Closed_By Bodge-IT

Add a Comment

Login with GitHub to post a comment