Feeling Lucky
RTC
PR-5.1-dev
[#42959] - [5.1] Form validation: throw error instead of warning
- Fixed in Code Base
- 14 Mar 2024
- Medium
- Build: 5.1-dev
- # 42959
- Diff
- Hackwar:5.1-form-validation-msg
User tests: Successful: Unsuccessful:
Summary of Changes
In PR #42911 we discovered that a missing required field creates an error message in the frontend validation. The validation in the backend however creates a warning message instead. This PR unifies that to both create error messages.
Testing Instructions
- Create/edit an article and in the browser console edit the category field
- remove the required class from the select-element and change the value of the selected category to an empty string.
- Click on save.
Actual result BEFORE applying this Pull Request
You get a warning message that category is required.
Expected result AFTER applying this Pull Request
You get an error message that category is required.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-5.1-dev
|
||
| Category | Libraries | ⇒ | Administration com_config com_finder com_languages com_menus com_messages com_templates Front End com_users Libraries |
viocassel
- comment
- 11 Mar 2024
I have tested this item ✅ successfully on 2418b68
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42959.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 11 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42959.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-14 12:51:10 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
bembelimen
- comment
- 14 Mar 2024
Thx
I have tested this item ✅ successfully on 2418b68
On the test procedure: I just clicked the x to remove the default category. Only tested in Administrator - is that right?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42959.