Feeling Lucky
RTC
bug
PR-5.1-dev
[#42956] - [5.1] Fix PHP warnings on newly created custom fields
- Fixed in Code Base
- 11 May 2024
- Medium
- Build: 5.1-dev
- # 42956
- Diff
- Quy:40681-fields
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40681 .
Summary of Changes
Separate conditions of the if statement to apply to new fields vs existing fields accordingly.
When creating a new field and the Search Index setting is Don't make searchable, the last 2 conditions are not applicable thus php warnings.
PHP Warning: Attempt to read property "params" on null in \administrator\components\com_fields\src\Model\FieldModel.php on line 123
PHP Warning: Trying to access array offset on value of type null in \administrator\components\com_fields\src\Model\FieldModel.php on line 123
Testing Instructions
Install Blog Sample Data.
No errors in PHP log.
Add a new custom field.
Save field.
No errors in PHP log.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
bug
PR-5.1-dev
|
||
exlemor
- comment
- 11 Apr 2024
I have tested this item ✅ successfully on 51b02c0
I was able to test this successfully - tested every field type - no error log entries.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42956.
cybersalt
- comment
- 11 Apr 2024
Try as I may, I could not get these errors even before the patch.
viocassel
- comment
- 15 Apr 2024
I have tested this item ✅ successfully on 51b02c0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42956.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 15 Apr 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42956.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-05-11 19:56:07 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
bembelimen
- comment
- 11 May 2024
Thx
Three times nested if conditions do look for me as not the right fix. Probably adding some comments to the existing one would be a better solution.