Feeling Lucky
RTC
Composer Dependency Changed
PR-5.1-dev
[#42954] - [5.1] replace web-token/signature-pack with web-token/jwt-library
- Fixed in Code Base
- 7 Mar 2024
- Medium
- Build: 5.1-dev
- # 42954
- Diff
- heelc29:5.1/issue-42952
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Possible Pull Request for Issue #42952 .
Summary of Changes
replace abandoned composer packages
Testing Instructions
run composer install
Actual result BEFORE applying this Pull Request
warning
Expected result AFTER applying this Pull Request
no warning
Additional comments
Removed packages do not contain relevant files
only web-token/jwt-experimental ...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
laoneo
- comment
- 5 Mar 2024
I have tested this item ✅ successfully on e9bf761
No abandoned warnings
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42954.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Composer Dependency Changed
PR-5.1-dev
|
||
richard67
- comment
- 5 Mar 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42954.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-07 12:45:30 |
| Closed_By | ⇒ | bembelimen |
bembelimen
- comment
- 7 Mar 2024
Thanks
I have tested this item ✅ successfully on e9bf761
The removed sub-dependencies consisted only of a readme file, the PHP files were already removed with the update from PR #42945 .
So we lose nothing with this PR here.
Unit tests, integration tests and system tests are successful, too.
However it needs to add some more deleted files and folders to script.php. I will make a follow-up PR for that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42954.