[#42951] - [5.1] Update deleted files list in script.php for 5.1.0-beta1 (2)
- Fixed in Code Base
- 4 Mar 2024
- Medium
- Build: 5.1-dev
- # 42951
- Diff
- richard67:5.1-dev-deleted-files-and-folders-2024-03-04
User tests: Successful: Unsuccessful:
Pull Request for Issue #42945 (comment) .
Summary of Changes
This pull request (PR) updates the lists of files and folders to be deleted on update in file administrator/components/com_admin/script.php by the changes from PR #42945 in the 5.1-dev branch in preparation for the upcoming 5.1.0-beta1 release.
All files and folders are caused by a restructuring of the composer dependency "web-token" coming with the update of that dependency.
Testing Instructions
Code review.
Or if you want to make a real test:
On the current 5.1-dev branch as it is right now, build new packages using the following command:
php ./build/build.php --remote=HEAD --exclude-gzip --exclude-zstd.
Save the created full installation package somewhere.
Download the full installation package of the latest 5.1 nightly build from tonight.
Compare the 2 packages.
Check the changes made by this PR.
Actual result BEFORE applying this Pull Request
The files and folders below the "libraries/vendor/web-token" which were removed when comparing the current build with the latest nightly are not in the lists of files and folders in script.php.
Expected result AFTER applying this Pull Request
The files and folders below the "libraries/vendor/web-token" which were removed when comparing the current build with the latest nightly are in the lists of files and folders in script.php.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
Might be a silly question, but why target each individual file to be deleted when you've already defined the directory?
@C-Lodder This has been discussed in past, I just don't have the time now to search for it. You are right that this would not be necessary, but we did it like that since 4.0.0 and it is easier to verify the list.
P.S.: One reason why we had to do it like that in J4 was because after we deleted all files we checked for custom template override files to be moved when converting the core templates from classic to child templates, and that check was easier after the core files were removed but before the folders were removed. In J5 this reason has become obsolete, so we could change that. But that should not be subject of this PR here, it just does it in the usual way.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-04 14:30:00 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
PR-5.1-dev
|
||
Thank you @richard67 ?
Might be a silly question, but why target each individual file to be deleted when you've already defined the directory?