Joomla! Issue Tracker | Joomla! CMS #42918 - [5.0] Modal Select title never gets translated

No Code Attached Yet Information Required bug

Closed
2 Aug 2024
Medium
Build: 4.4-dev
# 42918

peter1szalatnay
29 Feb 2024

Steps to reproduce the issue

Notices that when you use titleSelect="COM_X_FIELD_X_LABEL" in a modal select XML it will never get translated as there is no Text::_() on the button in the code below.

joomla-cms/layouts/joomla/form/field/modal-select/buttons.php

Line 57 in be506c0

'textHeader' => $modalTitles['select'] ?? Text::_('JSELECT'),

One more thing is that if you don't set the titleSelect the title is empty as the sting value will always return true and Text::_('JSELECT') is never selected either.

Expected result

Modal title should be translated.

Actual result

Modal title is not translated.

System information (as much as possible)

phpversion: 8.2.11
server: nginx/1.23.1
version: Joomla! 5.0.3 Stable [ Kuboresha ] 20-February-2024 16:00 GMT

Additional comments

peter1szalatnay - open - 29 Feb 2024

joomla-cms-bot - change - 29 Feb 2024

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 29 Feb 2024

Hackwar - change - 26 Mar 2024

Labels

Added: bug

Hackwar - labeled - 26 Mar 2024

brianteeman - comment - 7 May 2024

If you look at all the instances of this code you will see that Text:: is applied when the button is defined eg

joomla-cms/administrator/components/com_banners/src/View/Banners/HtmlView.php

Lines 197 to 204 in e26313a

    
               $childBar->popupButton('batch', 'JTOOLBAR_BATCH') 
        
                   ->popupType('inline') 
        
                   ->textHeader(Text::_('COM_BANNERS_BATCH_OPTIONS')) 
        
                   ->url('#joomla-dialog-batch') 
        
                   ->modalWidth('800px') 
        
                   ->modalHeight('fit-content') 
        
                   ->listCheck(true); 
        
           }

Quy - change - 7 May 2024

Labels

Added: Information Required

Quy - labeled - 7 May 2024

Quy - change - 2 Aug 2024

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2024-08-02 20:54:42
Closed_By		⇒	Quy

Quy - close - 2 Aug 2024

Fedik - comment - 3 Aug 2024

It is actually valid bug. Please test the fix #43878

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#42918] - [5.0] Modal Select title never gets translated

Steps to reproduce the issue

Expected result

Actual result

System information (as much as possible)

Additional comments

Add a Comment

	$childBar->popupButton('batch', 'JTOOLBAR_BATCH')
	->popupType('inline')
	->textHeader(Text::_('COM_BANNERS_BATCH_OPTIONS'))
	->url('#joomla-dialog-batch')
	->modalWidth('800px')
	->modalHeight('fit-content')
	->listCheck(true);
	}