[#42893] - [5.3] Trim email before password reset request
- Pending
- Medium
- Build: 4.4-dev
- # 42893
- Diff
- Hackwar:4.4-user-reset
User tests: Successful: Unsuccessful:
Pull Request for Issue #42374.
Summary of Changes
When typing in the email adress and accidentally adding a space at the front, the process fails. See the original issue linked above.
I read the original issue and I'm not sure if this is a bug or a feature or if we even want to interfer this way with this, but I decided to create a PR anyway, since it is easier to discuss with code directly instead of hypotheticals.
Testing Instructions
Type in your email adress with a space at the beginning.
Actual result BEFORE applying this Pull Request
Password reset fails.
Expected result AFTER applying this Pull Request
Password reset works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
Personaly this is expected and intended behaviour and should not be accepted
would move it to 5.2, btw. if you already trim the email you could lowercase it too in php but I think it doesn't has an performance impact in sql
| Title |
|
||||||
| Labels |
Added:
Feature
PR-4.4-dev
PR-5.2-dev
|
||
that a great improvement for User Experience, thank you. I tested it but it does not work
I have tested this item ? unsuccessfully on 95be583
Firefox doesn't see it as an email address when I type in a space first.
Google Chrome does, and before AND after applying the patch, I get a message that the email is sent.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42893.
I have tested this item ✅ successfully on 95be583
Tested successfully with 5.2-dev
- The user used could not have the superuser role, as no password reset mails are sent to them
- It was already working before the patch as ¿all? modern browsers remove leading spaces for email fields (verified with Chrome developer tools inspecting network request)
- Used one and multiple spaces before email address
- Tested with 'Forgot your password?' and 'Forgot your username?'
- Using emails with spaces before is still working after applying the PR
- The interesting question is the used browser in the issue?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42893.
Email was sent before and after applying patch - in theory, because I tested on a PBF server site that didn't send emails at all. So maybe the unsuccessful test should be removed.
So maybe the unsuccessful test should be removed
mark "not tested" at issue trackerand "submit test result".
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42893.
Yayyy, that worked, thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42893.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
I remember I looked at this issue at PBF but could not replicate it for some reasons. If we want to trim space like this, I think we should add
filter="TRIM"to the field, beforevalidate="email"https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_users/forms/reset_request.xml#L10 instead