[#42874] - [4.x] Allow folders with image extensions in media manager
- Fixed in Code Base
- 24 Feb 2024
- Medium
- Build: 4.4-dev
- # 42874
- Diff
- SniperSister:fix/4.4-mediamanagerdirnames
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Currently the mediamanager will return an error if a folder with an image extension is present in the media directory, as it (unsuccessfully) tries to fetch the image properties of such a directory. This PR fixes the issue.
Testing Instructions
- Create the directory "text.jpg" in the /images folder
- Open the media manager in the backend
Actual result BEFORE applying this Pull Request
Error message "The image file does not exist." is shown.
Expected result AFTER applying this Pull Request
Message is gone, media manager works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item ✅ successfully on dac28cf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.
When Error Reporting is set to maximum in Global Configuration, even with this patch, the media manager is not working at all, because the json produces the Notice:
Notice: exif_imagetype(): Read of 8192 bytes failed with errno=21 Is a directory in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93 Notice: exif_imagetype(): Error reading from /var/www/html/images/text.jpg! in /var/www/html/libraries/src/Helper/MediaHelper.php on line 93
| Labels |
Added:
RTC
bug
PR-4.4-dev
|
||
@tomsrocket excellent catch! PR has been updated, please retry! @TLWebdesign, can you have a look again too please?
my memory says that there was an open issue for this but my search skills fail to find it
my memory says that there was an open issue for this but my search skills fail to find it
Same here. I stumbled upon various issues with non-utf8 filenames, but these are completely different scenarios.
@SniperSister @brianteeman Maybe this one #39263 ?
I now get this error when looking at the media manager when error reporting is set to full.
Yeah, and you know why? Because I'm stupid!
Fixed now too, sorry, my bad!
Oh hahahaha i thought it was because i did something wrong. just reapplied it before reading your comment and it was working. Haha already deleted my comment because i thought i did something wrong haha.
Its working now.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. Please test again. Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.
I have tested this item ✅ successfully on 5ead192
Tested the changes and now it works even with error reporting set to maximum.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.
I have tested this item ✅ successfully on 5ead192
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-24 19:47:51 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item ✅ successfully on dac28cf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42874.