RTC PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
24 Feb 2024

Pull Request for Issue #42477.

Summary of Changes

There is a bug in System - Page Cache plugin causes Exclude URLs never works as explained in original issue. This PR just fixes that issue. Plus I change the code for checking URLs exclusion to use the same code like in Joomla 3 because:

  • It is easier to read
  • It is faster because it uses early return, so it not having to loop over all array elements.

Testing Instructions

  1. Uses Joomla 4.4
  2. Create a menu item to link to a Joomla article, set it's alias to something like test-page-cache-exclusion (this alias will will be configured in Exclude URLs parameter)
  3. Edit System - Page Cache plugin, look at Advanced tab, enter Alias of the menu item which you created above into Exclude URLs parameter. Make sure Status set to Enabled, save it.

Actual result BEFORE applying this Pull Request

The page is always being cached. To see that, you can access to that menu item for the first page. Then try to edit code in the file components/com_content/tmpl/article/default.php , add some random string to it. Then access to the menu item again, you do not see any change (because the system uses a cached version of the page)

Expected result AFTER applying this Pull Request

The page is not being cached as expected. To see that, you can access to that menu item for the first page. Then try to edit code in the file components/com_content/tmpl/article/default.php , add some random string to it. Then access to the menu item again, you will see the change you applied.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomdonation joomdonation - open - 24 Feb 2024
avatar joomdonation joomdonation - change - 24 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2024
Category Front End Plugins
avatar TLWebdesign TLWebdesign - test_item - 24 Feb 2024 - Tested successfully
avatar TLWebdesign
TLWebdesign - comment - 24 Feb 2024

I have tested this item ✅ successfully on 1deb336


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42871.

eb2b1c4 24 Feb 2024 avatar Quy phpcs
avatar Quy Quy - change - 24 Feb 2024
Labels Added: PR-4.4-dev
avatar Hackwar Hackwar - test_item - 26 Feb 2024 - Tested successfully
avatar Hackwar
Hackwar - comment - 26 Feb 2024

I have tested this item ✅ successfully on eb2b1c4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42871.

avatar Hackwar Hackwar - change - 26 Feb 2024
Status Pending Ready to Commit
avatar Hackwar
Hackwar - comment - 26 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42871.

avatar laoneo laoneo - change - 4 Mar 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-04 13:01:01
Closed_By laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 4 Mar 2024
avatar laoneo laoneo - merge - 4 Mar 2024
avatar laoneo
laoneo - comment - 4 Mar 2024

Thanks!

Add a Comment

Login with GitHub to post a comment