[#42864] - [4.4] fix cli scheduler:run breaks if --live-site does not end with /
- Pending
- Medium
- Build: 4.4-dev
- # 42864
- Diff
- svanschu:4.4-dev-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #42859 .
Summary of Changes
Adding a check if SCRIPT_NAME starts with a / or if HTTP_HOST ends with a /
If both checks are false add a / to prevent invalid URLs
Testing Instructions
This line fails
php cli/joomla.php scheduler:run -i 1 --live-site 'http://localhost:43000'
number 1 is the rotate Logs task, but it happens with any other as well
for testing this framework PR is needed as well joomla-framework/application#123
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Successful run
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-4.4-dev
|
||
| Category | Libraries | ⇒ | External Library Composer Change Libraries |
| Labels |
Added:
Composer Dependency Changed
|
||
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.
composer update is unrelated. Beside that a url starts always with a slash so a live site looks always like https://example.com/ the last / is the identifier of the location. But I don't care if others thinks it's ok then it can be merged (wouldn't do it in 4.x branch at least)