[#42863] - [4.4] com_scheduler - Update ExecutionRulesRule to validate custom cron expression correctly
- Fixed in Code Base
- 4 Mar 2024
- Medium
- Build: 4.4-dev
- # 42863
- Diff
- n3t:n3t-patch-com_scheduler
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Avoid fatal PHP error on saving Task with incorrect user input.
Testing Instructions
Create new task in com_scheduler, select "Cron Expression (Advanced)" as "Execution Rule", do not choose any Minute, Hour, Day, Month or Day of Week in Cron Match section and save. Sames apply if you choose only some of these but not all.
Actual result BEFORE applying this Pull Request
PHP Error
Joomla\Component\Scheduler\Administrator\Model\TaskModel::wildcardIfMatch(): Argument #1 ($target) must be of type array, null given, called in ../administrator/components/com_scheduler/src/Model/TaskModel.php on line 637
Expected result AFTER applying this Pull Request
Warning is raised, task not saved. User can correct input and save again.
Additional info
Modified the Rule to reflect real cron expression rule type (it is not custom but cron-expression), plus added required for subsequent fields in validation.
Applies to Joomla 5 also.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Title |
|
||||||
@Quy not an alternative but a required additional #37536 (comment)
With PR only 3 fields are missing:
correct the missing fields 2 more fields are missing:
All missing fields should show at once.
This is Joomla standard, show only up to 3 errors and is caused directly by FormController. Doesn't have to do anything with this PR. I do not think we should override this behavior just for this use case...
I have tested this item ✅ successfully on 54e89cf
Thanks for explanation @n3t.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42863.
I have tested this item ✅ successfully on 54e89cf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42863.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42863.
| Labels |
Added:
RTC
PR-4.4-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-04 13:03:25 |
| Closed_By | ⇒ | laoneo |
Thanks!
Alternative PR #37536 using JavaScript.