[#42861] - [5.2] Fix of unnecessary SQL query for Fields, get the field value already loaded by getFields()
- Fixed in Code Base
- 30 Apr 2024
- Medium
- Build: 5.1-dev
- # 42861
- Diff
- Fedik:fields-fx1
User tests: Successful: Unsuccessful:
Summary of Changes
Remove unnecessary SQL query for the custom fields, during the form rendering.
FieldsHelper::getFields() load the field value, however FieldsHelper::prepareForm() also loading them wthout a reason.
Also removed some dead code.
Testing Instructions
Enable debug and debug query.
Create a couple of Custom fields, let say 10.
Open article editing.
Actual result BEFORE applying this Pull Request
Notice amount of query in debug.
Let say 75
Expected result AFTER applying this Pull Request
The amount of query will be 10 less, 65
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
I have tested this item ✅ successfully on 59bd3b7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.
I have tested this item ✅ successfully on 59bd3b7
Its ok Queries have decreased
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.
shuldn't that go into 4.4?
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.
Is the unnecessary query an issue in 4.4, too?
yeap,
I will do another, later
During PBF
16 Content Article - Custom fields (my Group),
before patch 67 queries, after patch 51 queries
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-25 12:01:39 |
| Closed_By | ⇒ | Fedik | |
| Labels |
Added:
RTC
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2024-02-25 12:01:39 | ⇒ | |
| Closed_By | Fedik | ⇒ | |
| Labels |
Removed:
RTC
|
||
| Status | New | ⇒ | Pending |
I've restored the previous human test results as the PR was closed but then reopened, and there was no change since the successful tests.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.
| Title |
|
||||||
I moved it to 5.2 as a decision from maintainer
| Labels |
Added:
RTC
PR-5.2-dev
Removed: PR-5.1-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-30 08:23:56 |
| Closed_By | ⇒ | pe7er |
I have tested this item ✅ successfully on 59bd3b7
Before: 61 queries. After: 51 queries.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42861.