Feeling Lucky
RTC
PR-5.1-dev
[#42838] - [5.1] Convert mod_toolbar to service provider
- Fixed in Code Base
- 24 Feb 2024
- Medium
- Build: 5.1-dev
- # 42838
- Diff
- joomlaweby:mod_toolbar
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the toolbar administrator module to service provider.
Testing Instructions
- Make sure you have administrator module mod_toolbar published
- You should see module output
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
PR-5.1-dev
|
||
fgsw
- comment
- 21 Feb 2024
I have tested this item ✅ successfully on d3bca7b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42838.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 21 Feb 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42838.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-24 19:51:23 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 24 Feb 2024
Thank you @joomlaweby and also testing @ceford @fgsw
I have tested this item ✅ successfully on d3bca7b
Applied patch and looked at several admin pages - all toolbars worked normally (included logout/login).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42838.