User tests: Successful: Unsuccessful:
Pull Request for Issue #41930.
The entries in the filters in Smart Search aren't properly ordered in the frontend.
The categories are pretty much random.
The categories are displayed properly like in the tree structure.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_finder |
Labels |
Added:
bug
PR-5.0-dev
|
@richard67 See the last discussion we had about this. Nothing has changed since then.
@richard67 See the last discussion we had about this. Nothing has changed since then.
@Hackwar So you think you as the JBS Team Lead and a member of the CMS Maintenance Team can do as you like and ignore all our policies?
I'm not ignoring policies. However I refuse to waste my time arguing if something is a bug and worthy of fixing in Joomla 4.4 and rather take the shortcut of providing that fix to 5.0+. Since the relevant maintainer decided to ignore this for over a week now as well, I'm assuming that it is fine the way I'm doing it.
I have tested this item ✅ successfully on 55139c2
Status | Pending | ⇒ | Ready to Commit |
RTC as it has 2 successful tests. Release managers pls. decide if it should go into 5.0-dev or 4.4-dev.
Labels |
Added:
RTC
RMDQ
|
Category | Administration com_finder | ⇒ | Administration com_banners com_categories com_config com_contact com_content com_finder com_languages com_menus com_newsfeeds com_tags com_users Language & Strings Templates (admin) |
Title |
|
Category | Administration com_finder com_banners com_categories com_config com_contact com_content com_languages com_menus com_newsfeeds com_tags com_users Language & Strings Templates (admin) | ⇒ | Administration com_finder |
I've tested this on J5.1. I created some categories and subcategories in content and in contacts. I deliberately named some of the categories in contact and content categories the same.
At first it seemed to work. The sort order in the pull down menu is now correct. Is it intended that the duplicate category names from the two different components are the shown as one?
After some testing the search didn't work for content anymore. Even if I turn of all other search plugins, and leave content the only one turned on. I did rebuild the smart search index. The advanced search does show the content categories, but whatever search word I enter, there's no result. If I turn on search for contacts, the contacts will be found, but no articles will show up.
I revoked the patch, and still the content search doesn't work anymore.
Status | Ready to Commit | ⇒ | Pending |
Back to pending after rebase.
Labels |
Added:
PBF
PR-4.4-dev
Removed: RTC RMDQ PR-5.0-dev |
With J 5.1, the display after patching does not change.
I made a category and subcategory
##ACCESSIBILITY IDEA
I searched for the subcategory with its own prefix and found nothing, so I infer that the query does a search with the = operator. You can vary the search query with a
LIKE '%''++'%'?
@stimpsonjcat Your issues are unrelated to this PR. This PR only touches the order of the entries in the filters.
@adj9 That is already an option in the component configuration of Smart Search. Also,if you only have 2 categories, there is nothing which could change, since they aren't out of order at that moment.
I did test it again. It seemed that my articles had disappeared on the pizza-bugs-and-fun server.
I did test it again in 5.1 alpha 3 and retested on the testserver of today. It works as expected. ✅
The only feature request I would suggest: if you have a top level category (i.e. red) and and a sublevel category (i.e. light red), I would expect, as an enduser, if I search in the top-level I would also find results in the sublevel.
I did test it again. It seemed that my articles had disappeared on the pizza-bugs-and-fun server. I did test it again in 5.1 alpha 3 and retested on the testserver of today. It works as expected. ✅
@stimpsonjcat Could you use the blue "Test this" button in the issue tracker https://issues.joomla.org/tracker/joomla-cms/42835 to submit your test result? Otherwise it is not counted. Thanks in advance.
I have tested this item ✅ successfully on 4a8e9a1
Created multiple categories and subcategories in content and in contacts.
Added some articles and contacts. Some contacts have the same word in the name as in the article. (I've written an article on Stefanie and added a contact named Stefanie)
In the frontend searched on Stefanie and clicked on the advanced search. The category dropdown now shows the categories in the correct alphabetical order and hierarchy. The categories with the same names in content and contacts are shown as one category.
I have tested this item ✅ successfully on 4a8e9a1
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
Updates Requested
|
Just to be safe: can we have another test here?
Status | Ready to Commit | ⇒ | Pending |
Back to pending
No good! With the patch applied I see the list in order but part of the Sample Data Articles is repeated.
Why do you want another test for this?
I'm getting errors in Joomla 5.1.0-alpha4:
Warning: Undefined property: stdClass::$id in /administrator/components/com_finder/src/Indexer/Result.php on line 576
Warning: Attempt to read property "state" on array in /administrator/components/com_finder/src/Indexer/Result.php on line 577
Warning: Attempt to read property "access" on array in /administrator/components/com_finder/src/Indexer/Result.php on line 578
I'm getting errors in Joomla 5.1.0-alpha4:
@stimpsonjcat How is this related to this PR here which is clearly made for 4.4-dev and not 5.1-dev?
I have tested this item ✅ successfully on ded674e
Oops - my previous comments were for J5. J4 Seems to work fine.
Labels |
Removed:
RTC
Updates Requested
|
As we added only a type to a function argument, one test is enough. So merging it as it was RTC before.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-05 07:19:16 |
Closed_By | ⇒ | laoneo |
Thanks!
I have tested this item ✅ successfully on 55139c2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.