PBF bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
19 Feb 2024

Pull Request for Issue #41930.

Summary of Changes

The entries in the filters in Smart Search aren't properly ordered in the frontend.

Testing Instructions

  1. Create a website with some content, especially nested categories. Best solution would be to use the testing sampledata.
  2. Go to the Smart Search search view in the frontend and open the advanced filters
  3. Check for example the category filter

Actual result BEFORE applying this Pull Request

The categories are pretty much random.

Expected result AFTER applying this Pull Request

The categories are displayed properly like in the tree structure.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 19 Feb 2024
avatar Hackwar Hackwar - change - 19 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2024
Category Administration com_finder
avatar Hackwar Hackwar - change - 20 Feb 2024
Labels Added: bug PR-5.0-dev
avatar ceford ceford - test_item - 20 Feb 2024 - Tested successfully
avatar ceford
ceford - comment - 20 Feb 2024

I have tested this item ✅ successfully on 55139c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar richard67
richard67 - comment - 20 Feb 2024

@Hackwar Shouldn’t this be fixed in the 4.4-dev branch? The issue was reported for 4.3.

avatar Hackwar
Hackwar - comment - 20 Feb 2024

@richard67 See the last discussion we had about this. Nothing has changed since then.

avatar richard67
richard67 - comment - 20 Feb 2024

@richard67 See the last discussion we had about this. Nothing has changed since then.

@Hackwar So you think you as the JBS Team Lead and a member of the CMS Maintenance Team can do as you like and ignore all our policies?

avatar Hackwar
Hackwar - comment - 20 Feb 2024

I'm not ignoring policies. However I refuse to waste my time arguing if something is a bug and worthy of fixing in Joomla 4.4 and rather take the shortcut of providing that fix to 5.0+. Since the relevant maintainer decided to ignore this for over a week now as well, I'm assuming that it is fine the way I'm doing it.

avatar fgsw fgsw - test_item - 21 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 21 Feb 2024

I have tested this item ✅ successfully on 55139c2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar richard67 richard67 - change - 21 Feb 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 21 Feb 2024

RTC as it has 2 successful tests. Release managers pls. decide if it should go into 5.0-dev or 4.4-dev.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar Hackwar Hackwar - change - 21 Feb 2024
Labels Added: RTC RMDQ
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2024
Category Administration com_finder Administration com_banners com_categories com_config com_contact com_content com_finder com_languages com_menus com_newsfeeds com_tags com_users Language & Strings Templates (admin)
avatar Hackwar Hackwar - change - 21 Feb 2024
Title
[5.0] Smart Search: Properly sort filters
[4.4] Smart Search: Properly sort filters
avatar Hackwar Hackwar - edited - 21 Feb 2024
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2024
Category Administration com_finder com_banners com_categories com_config com_contact com_content com_languages com_menus com_newsfeeds com_tags com_users Language & Strings Templates (admin) Administration com_finder
avatar stimpsonjcat
stimpsonjcat - comment - 24 Feb 2024

I've tested this on J5.1. I created some categories and subcategories in content and in contacts. I deliberately named some of the categories in contact and content categories the same.
At first it seemed to work. The sort order in the pull down menu is now correct. Is it intended that the duplicate category names from the two different components are the shown as one?

After some testing the search didn't work for content anymore. Even if I turn of all other search plugins, and leave content the only one turned on. I did rebuild the smart search index. The advanced search does show the content categories, but whatever search word I enter, there's no result. If I turn on search for contacts, the contacts will be found, but no articles will show up.

I revoked the patch, and still the content search doesn't work anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar richard67 richard67 - change - 24 Feb 2024
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 24 Feb 2024

Back to pending after rebase.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar Hackwar Hackwar - change - 24 Feb 2024
Labels Added: PBF PR-4.4-dev
Removed: RTC RMDQ PR-5.0-dev
avatar adj9
adj9 - comment - 24 Feb 2024

With J 5.1, the display after patching does not change.
I made a category and subcategory

##ACCESSIBILITY IDEA
I searched for the subcategory with its own prefix and found nothing, so I infer that the query does a search with the = operator. You can vary the search query with a
LIKE '%''++'%'?

avatar Hackwar
Hackwar - comment - 24 Feb 2024

@stimpsonjcat Your issues are unrelated to this PR. This PR only touches the order of the entries in the filters.

@adj9 That is already an option in the component configuration of Smart Search. Also,if you only have 2 categories, there is nothing which could change, since they aren't out of order at that moment.

avatar stimpsonjcat
stimpsonjcat - comment - 24 Feb 2024

I did test it again. It seemed that my articles had disappeared on the pizza-bugs-and-fun server.
I did test it again in 5.1 alpha 3 and retested on the testserver of today. It works as expected. ✅

The only feature request I would suggest: if you have a top level category (i.e. red) and and a sublevel category (i.e. light red), I would expect, as an enduser, if I search in the top-level I would also find results in the sublevel.

avatar richard67
richard67 - comment - 24 Feb 2024

I did test it again. It seemed that my articles had disappeared on the pizza-bugs-and-fun server. I did test it again in 5.1 alpha 3 and retested on the testserver of today. It works as expected. ✅

@stimpsonjcat Could you use the blue "Test this" button in the issue tracker https://issues.joomla.org/tracker/joomla-cms/42835 to submit your test result? Otherwise it is not counted. Thanks in advance.

avatar stimpsonjcat stimpsonjcat - test_item - 24 Feb 2024 - Tested successfully
avatar stimpsonjcat
stimpsonjcat - comment - 24 Feb 2024

I have tested this item ✅ successfully on 4a8e9a1

Created multiple categories and subcategories in content and in contacts.
Added some articles and contacts. Some contacts have the same word in the name as in the article. (I've written an article on Stefanie and added a contact named Stefanie)
In the frontend searched on Stefanie and clicked on the advanced search. The category dropdown now shows the categories in the correct alphabetical order and hierarchy. The categories with the same names in content and contacts are shown as one category.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.
avatar eddiekonczal eddiekonczal - test_item - 24 Feb 2024 - Tested successfully
avatar eddiekonczal
eddiekonczal - comment - 24 Feb 2024

I have tested this item ✅ successfully on 4a8e9a1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar Quy Quy - change - 24 Feb 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar MacJoom MacJoom - change - 4 Mar 2024
Labels Added: RTC Updates Requested
avatar MacJoom
MacJoom - comment - 4 Mar 2024

Just to be safe: can we have another test here?

avatar laoneo laoneo - change - 4 Mar 2024
Status Ready to Commit Pending
avatar laoneo
laoneo - comment - 4 Mar 2024

Back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar ceford
ceford - comment - 4 Mar 2024

No good! With the patch applied I see the list in order but part of the Sample Data Articles is repeated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.
avatar Hackwar
Hackwar - comment - 4 Mar 2024

Why do you want another test for this?

avatar Hackwar
Hackwar - comment - 4 Mar 2024

@ceford can you please be a bit more specific? What do you see repeated where?

avatar ceford
ceford - comment - 4 Mar 2024

image

avatar stimpsonjcat
stimpsonjcat - comment - 4 Mar 2024

I'm getting errors in Joomla 5.1.0-alpha4:

Warning: Undefined property: stdClass::$id in /administrator/components/com_finder/src/Indexer/Result.php on line 576

Warning: Attempt to read property "state" on array in /administrator/components/com_finder/src/Indexer/Result.php on line 577

Warning: Attempt to read property "access" on array in /administrator/components/com_finder/src/Indexer/Result.php on line 578

avatar richard67
richard67 - comment - 4 Mar 2024

I'm getting errors in Joomla 5.1.0-alpha4:

@stimpsonjcat How is this related to this PR here which is clearly made for 4.4-dev and not 5.1-dev?

avatar ceford ceford - test_item - 4 Mar 2024 - Tested successfully
avatar ceford
ceford - comment - 4 Mar 2024

I have tested this item ✅ successfully on ded674e

Oops - my previous comments were for J5. J4 Seems to work fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42835.

avatar Quy Quy - change - 4 Mar 2024
Labels Removed: RTC Updates Requested
avatar laoneo
laoneo - comment - 5 Mar 2024

As we added only a type to a function argument, one test is enough. So merging it as it was RTC before.

avatar laoneo laoneo - change - 5 Mar 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-03-05 07:19:16
Closed_By laoneo
avatar laoneo laoneo - close - 5 Mar 2024
avatar laoneo laoneo - merge - 5 Mar 2024
avatar laoneo
laoneo - comment - 5 Mar 2024

Thanks!

Add a Comment

Login with GitHub to post a comment