RTC Language Change PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
18 Feb 2024

Pull Request for PR #42692 #42702 #42704 .

Summary of Changes

Add note to gloabl configuration for additional options in system plugin SEF

grafik

Testing Instructions

  • Apply patch
  • open global configuration /administrator/index.php?option=com_config

Actual result BEFORE applying this Pull Request

no notice shown

Expected result AFTER applying this Pull Request

notice shown in section/fieldset "SEO"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 18 Feb 2024
avatar LadySolveig LadySolveig - change - 18 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2024
Category Administration com_config Language & Strings Layout
avatar LadySolveig LadySolveig - change - 18 Feb 2024
Labels Added: Language Change PR-5.1-dev
avatar Hackwar Hackwar - test_item - 19 Feb 2024 - Tested successfully
avatar Hackwar
Hackwar - comment - 19 Feb 2024

I have tested this item ✅ successfully on e42c9d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.

avatar Fedik
Fedik - comment - 19 Feb 2024

Sorry, this looks wrong, the layout already have "description" rendering,

<?php if (!empty($displayData->description)) : ?>
<p><?php echo $displayData->description; ?></p>
<?php endif; ?>

Need to look why it does not work as expected.

avatar Hackwar
Hackwar - comment - 19 Feb 2024

No, this is a different description. $displayData->description is not filled from the XML. To be honest, the old code looks like it was never tested.

avatar Fedik
Fedik - comment - 19 Feb 2024

Then we have to fix that, instead of hardcoding.

From what I see the description already expected from $displayData->description
in same way as label done with $displayData->name

avatar Hackwar
Hackwar - comment - 19 Feb 2024

The fix is this PR here. $displayData->description is simply wrong.

avatar Fedik
Fedik - comment - 19 Feb 2024

Why?

avatar Fedik
Fedik - comment - 19 Feb 2024

The description need to be added here

$this->name = Text::_('COM_CONFIG_SEO_SETTINGS');

Beside $this->name:

$this->name = 'blabla name'
$this->description = 'blabla description';

But, this also means that every other layouts in ../tmpl/application should have "description":

$this->name = 'blabla name'
$this->description = '';

Otherwise, the last added description will be rendered in all following layouts.

avatar Hackwar
Hackwar - comment - 19 Feb 2024

Yes, and that is why this shouldn't be done like that. The whole layout obviously has only been created for the global configuration and has not been maintained properly so far. For example, the whole rendering of fields can be replaced with echo $displayData->form->renderFieldset($fieldname);.

avatar Fedik
Fedik - comment - 19 Feb 2024

Yes, and that is why this shouldn't be done like that. The whole layout obviously has only been created for the global configuration and has not been maintained properly so far.

Sorry, I cannot follow your logic.
We better stick to what we have here instead of hardcoding here and there.

If someone want to rewrite whole rendering, well, I do not mind. But then it should be done for whole view, not only here.

avatar LadySolveig
LadySolveig - comment - 19 Feb 2024

@Fedik
#42692 (comment)
I have now simply taken up this approach for a different proposal.

<?php if (!empty($fieldSet->description)) : ?>

avatar Fedik
Fedik - comment - 19 Feb 2024

I understood that, but as you can see application view rendred diferently from component view.
I do not know why, but unless someone want to rewrite it, it is better to follow of what it is.

To have a better styling can probably change

<?php if (!empty($displayData->description)) : ?>
<p><?php echo $displayData->description; ?></p>
<?php endif; ?>

to:

<?php if (!empty($displayData->description)) : ?>
  <div class="alert alert-info">
    <span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
    <?php echo $displayData->description; ?>
  </div>
<?php endif; ?>

Similar to what you made, but with use of 'expected' description property.

avatar Fedik
Fedik - comment - 19 Feb 2024

@LadySolveig looks good now, thanks!

avatar ceford ceford - test_item - 20 Feb 2024 - Tested successfully
avatar ceford
ceford - comment - 20 Feb 2024

I have tested this item ✅ successfully on e8f9963


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.

avatar Quy Quy - test_item - 20 Feb 2024 - Tested successfully
avatar Quy
Quy - comment - 20 Feb 2024

I have tested this item ✅ successfully on e8f9963


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.

avatar Quy Quy - change - 20 Feb 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.

avatar Quy Quy - change - 20 Feb 2024
Labels Added: RTC
avatar crimle crimle - test_item - 24 Feb 2024 - Tested successfully
avatar crimle
crimle - comment - 24 Feb 2024

I have tested this item ✅ successfully on c9f426a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.

avatar dorisdreher dorisdreher - test_item - 24 Feb 2024 - Tested successfully
avatar dorisdreher
dorisdreher - comment - 24 Feb 2024

I have tested this item ✅ successfully on c9f426a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.

avatar bembelimen bembelimen - change - 28 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-28 17:41:21
Closed_By bembelimen
avatar bembelimen bembelimen - close - 28 Feb 2024
avatar bembelimen bembelimen - merge - 28 Feb 2024
avatar bembelimen
bembelimen - comment - 28 Feb 2024

Thank you!

Add a Comment

Login with GitHub to post a comment