User tests: Successful: Unsuccessful:
Pull Request for PR #42692 #42702 #42704 .
Add note to gloabl configuration for additional options in system plugin SEF
/administrator/index.php?option=com_config
no notice shown
notice shown in section/fieldset "SEO"
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config Language & Strings Layout |
Labels |
Added:
Language Change
PR-5.1-dev
|
Sorry, this looks wrong, the layout already have "description" rendering,
joomla-cms/layouts/joomla/content/options_default.php
Lines 26 to 28 in e42c9d5
Need to look why it does not work as expected.
No, this is a different description. $displayData->description
is not filled from the XML. To be honest, the old code looks like it was never tested.
Then we have to fix that, instead of hardcoding.
From what I see the description already expected from $displayData->description
in same way as label done with $displayData->name
The fix is this PR here. $displayData->description
is simply wrong.
Why?
The description need to be added here
$this->name
:
$this->name = 'blabla name'
$this->description = 'blabla description';
But, this also means that every other layouts in ../tmpl/application
should have "description":
$this->name = 'blabla name'
$this->description = '';
Otherwise, the last added description will be rendered in all following layouts.
Yes, and that is why this shouldn't be done like that. The whole layout obviously has only been created for the global configuration and has not been maintained properly so far. For example, the whole rendering of fields can be replaced with echo $displayData->form->renderFieldset($fieldname);
.
Yes, and that is why this shouldn't be done like that. The whole layout obviously has only been created for the global configuration and has not been maintained properly so far.
Sorry, I cannot follow your logic.
We better stick to what we have here instead of hardcoding here and there.
If someone want to rewrite whole rendering, well, I do not mind. But then it should be done for whole view, not only here.
@Fedik
#42692 (comment)
I have now simply taken up this approach for a different proposal.
I understood that, but as you can see application
view rendred diferently from component
view.
I do not know why, but unless someone want to rewrite it, it is better to follow of what it is.
To have a better styling can probably change
joomla-cms/layouts/joomla/content/options_default.php
Lines 26 to 28 in e42c9d5
to:
<?php if (!empty($displayData->description)) : ?>
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo $displayData->description; ?>
</div>
<?php endif; ?>
Similar to what you made, but with use of 'expected' description
property.
@LadySolveig looks good now, thanks!
I have tested this item ✅ successfully on e8f9963
I have tested this item ✅ successfully on e8f9963
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
|
I have tested this item ✅ successfully on c9f426a
I have tested this item ✅ successfully on c9f426a
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-28 17:41:21 |
Closed_By | ⇒ | bembelimen |
Thank you!
I have tested this item ✅ successfully on e42c9d5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42832.