[#42829] - [5] [RFC] [cli] extension Update command
- Closed
- 11 Apr 2024
- Medium
- Build: 5.1-dev
- # 42829
- Diff
- alikon:update-command
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40693 .
Summary of Changes
if you want an extension to be installable from cli then add this tag <updatefromcli>true</updatefromcli> to the updateserver.xml
for example
new command to perform the extension updated
php cli\joomla.php extension:update --eid=extension_id
Testing Instructions
run php cli\joomla.php extension:update --eid=extension_id
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
run
php cli\joomla.php extension:update --eid=249
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Libraries |
| Labels |
Added:
PR-5.1-dev
|
||
doesn't that will fail from backend com_installer as well ?
No, an extension which does redirects after installation, maybe does ajax calls when the update is finished or expects a web context in generell, will fail with the update when you are in a CLI context.
that's is more like a general joomla issue
not all joomla api performs like a client agnostic
there already are plenty of issue reports about that
cli vs workflows just as a recent example
out of scope of this silly pr
Considering that this could pretty much destroy a website, I don't consider this something we should just risk. Yes, there are things which don't work right now, but that isn't a reason to introduce yet something else which is broken.
ok then
i'll split this in 2 pr
- one for the update:extensions:check
- and one RFC for the extension:update
| Title |
|
||||||
| Labels |
Added:
RFC
|
||
i've introduced a tag <updatefromcli>true</updatefromcli> for the updateserver.xml
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-04-11 19:14:20 |
| Closed_By | ⇒ | alikon |
no interest
I would strongly advise against this at this moment. We should first introduce a flag into extension manifests to mark if an extension supports updating via CLI, because otherwise especially the big extensions with their own install scripts will all fail when updating.