[#42825] - [5.1] Load Schema.org only in proper forms
- Fixed in Code Base
- 7 Jul 2024
- Medium
- Build: 5.0-dev
- # 42825
- Diff
- n3t:n3t-patch-schemaorg
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Load and display scheme.org form only in contexts that component propagate as available.
Summary of Changes
Modified Schemaorg system plugin to load Schema form only in contexts, that are promoted by component as available.
Testing Instructions
Not testable on core, as com_content and com_contact both has only one edit view, one edit form. Need 3rd party component with support of SchemaorgServiceInterface.
Dev version of PhocaCart could be used (not released at the moment). If necessary I could prepare dummy component just for testing this.
Actual result BEFORE applying this Pull Request
If the component provides multiple forms, schema.org form is added to all of its forms, not only to forms declared in
getSchemaorgContexts function.
Expected result AFTER applying this Pull Request
Schema org fields are loaded only on proper forms.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
|
||
I have tested this item ✅ successfully on 7d5f44f
Hi, I have installed the latest Phoca Cart Beta version, after installing this patch I don't see any extra unnecessary tab. So the result is successful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.
| Labels |
Added:
RTC
bug
|
||
| Labels |
Added:
PR-5.1-dev
Removed: PR-5.0-dev |
||
I have tested this item ✅ successfully on 660b142
Also used Phocacart in testing - it works.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.
HLeithner
- | Title |
|
||||||
I have tested this item ✅ successfully on 660b142
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.
Just curious, this PR is marked RTC since 3 months ago, but still not commited, so missing in 5.1.1 release, is there any issue with it? Should I add something?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-07 21:59:04 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item ✅ successfully on 7d5f44f
Hi,
testing with latest Phoca Cart 5 Beta version: https://github.com/PhocaCz/PhocaCart/releases/download/5.0.0Beta/com_phocacart_v5.0.0Beta26.zip
Before:
(additional tab is displayed)
After:
(no additional tab is displayed)
Tested sucessfully ✓
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42825.