PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
12 Feb 2024

Pull Request for Issue #42793 .

Summary of Changes

skip if publishDate is null

Testing Instructions

see #42793

Actual result BEFORE applying this Pull Request

deprecated Notice

Expected result AFTER applying this Pull Request

No deprecated Notice

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 12 Feb 2024
avatar alikon alikon - change - 12 Feb 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2024
Category Modules Front End
avatar fgsw fgsw - test_item - 12 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 12 Feb 2024

I have tested this item ✅ successfully on 93a4125

Thanks @alikon


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42795.

avatar viocassel viocassel - test_item - 12 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 12 Feb 2024

I have tested this item ✅ successfully on 93a4125


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42795.

avatar brianteeman
brianteeman - comment - 12 Feb 2024

Doesnt the same change need to be made to the admin feed module?

avatar alikon
alikon - comment - 12 Feb 2024

yes i'll add the same fix on the admin module too

avatar alikon alikon - change - 12 Feb 2024
Labels Added: PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2024
Category Modules Front End Modules Administration Front End
avatar viocassel viocassel - test_item - 12 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 12 Feb 2024

I have tested this item ✅ successfully on 705ef82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42795.

avatar richard67
richard67 - comment - 13 Feb 2024

@alikon Do we have the issue only in 5.x? Or also in 4.4? If in 4.4, shouldn’t it be fixed in the 4.4-dev branch?

avatar alikon
alikon - comment - 13 Feb 2024

Honestly i didn't check in 4.4 as the issue was reported from 5.0.3 i'll check later on 4.4

avatar alikon
alikon - comment - 13 Feb 2024

issue is present on 4.4 too i'll redo the pr on the 4.4 branch

avatar alikon
alikon - comment - 13 Feb 2024

please test #42803

avatar alikon alikon - change - 13 Feb 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-02-13 11:38:12
Closed_By alikon
avatar alikon alikon - close - 13 Feb 2024

Add a Comment

Login with GitHub to post a comment