Try porting over some of https://github.com/joomla/joomla-platform/tree/staging/tests/suites/unit/joomla/session and see what happens.

Well they all fail because I don't have an adpater class to inject in yet to replace the session_start crap. As I said you'd need a version of mock array session storage like https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Session/Storage/MockArraySessionStorage.php before you could run the tests

Did those tests ever pass?

Yes. All we're carried to the Framework except JSessionTest because of the
problems you listed here.

On Sunday, September 14, 2014, George Wilson notifications@github.com
wrote:

Did those tests ever pass?

—
Reply to this email directly or view it on GitHub
#4279 (comment).

Well I copied in the symfony package above and tests nearly pass. Getting name and id fail because the test is testing them against session_name() and session_id() which of course is different to the name/id being used by the array system.

getFormToken also fails. Not sure about that. Will push up that. Gotta focus on some other stuff now. But gives you an idea.

This is weird. travis is failing all the tests and using the "native" session bridges. It should be injecting the array based thing into all of them. Only 3 fail on my computer :(

I removed the skeletons because it was cluttering my pr when i was going through it for debug times ealier

I have no clue why these tests are failing. I tried a huge number of combo's and every time travis decides to play Gandalf

Create a new branch from this one and put some var_dumps into JSessionTest then change it so only that test is getting run on Travis. That should help give an idea what's going on, then when you figure it out you merge the fixes back onto this branch and the PR gets updated without all the extra history.

So I just ran the full suite locally and I'm getting the same errors as Travis. But the test runs fine in isolation. Which means there's something else in the test suite which is screwing up the test platform.

That might help. My computer has always errored when running the full test suite so not sure what the solution is :/

Ughh 10 fold increased my memory limit and got places. JSession::getInstance() is being called before this test in other places. So it's returning the statically stored variable which has the native handler

I have a new PR for you. We basically need to inject mocks into JFactory in a lot more places (and make sure that doesn't cause failures).

I've cheated. See latest commit. Agree your PR is better long term solution

Ya, that'll work. But it doesn't actually address the real problems in the testing platform. Let's try not to introduce more hacks please?

Squashed commits down a bit and rebased on master. Let's see how travis goes.