[#42774] - Time Zone form field to use groupedlist fancy select layout
- Fixed in Code Base
- 4 Mar 2024
- Medium
- Build: 4.4-dev
- # 42774
- Diff
- cyrezdev:patch-57
User tests: Successful: Unsuccessful:
Summary of Changes
Time Zone form field to use groupedlist fancy select layout.
This makes it easier to select the website or user time zone instead of scrolling through 420 time zones.
Testing Instructions
Install the patch and test Website Time Zone option (global config) as well as user Time Zone option in profile.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config com_users Front End Libraries |
| Labels |
Added:
PR-4.4-dev
|
||
Please fix phpcs https://ci.joomla.org/joomla/joomla-cms/73346/1/8
Thank you!
Oh yes... spaces... no tabs... :-D
I have tested this item ✅ successfully on 6a0fea5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.
Please rebase for v5.1 as this is not a bug. Thanks.
| Labels |
Added:
Feature
|
||
| Category | Administration com_config com_users Front End Libraries | ⇒ | Administration com_config com_users Front End |
| Category | Administration com_config com_users Front End | ⇒ | Administration com_config com_users Front End Libraries |
Please rebase for v5.1 as this is not a bug. Thanks.
Really?...
The first purpose was an improvement (not a new feature).
But, after comments from @laoneo and @rdeutz it appears i did it wrong. I redid it. And now it add a fix as well due to a choices.js issue: #42774 (comment)
If it's ok with my last update of this PR, i can rebase it if required. ;)
I have tested this item ✅ successfully on 5b772fa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.
I have tested this item ✅ successfully on 5b772fa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.
Tested in 5.1.0-alpha4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.
As @Fedik mentioned already, please rebase this one to 5.1. I'm also not sure about the inline comment. Can the change be reverted when Choices-js/Choices#1110 is merged and added into Joomla?
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to requested rebase.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.
As @Fedik mentioned already, please rebase this one to 5.1. I'm also not sure about the inline comment. Can the change be reverted when Choices-js/Choices#1110 is merged and added into Joomla?
Just rebased.
About the fix, this one could be removed when choices.js with the fix for isolated options integrated.
It won't be an issue as the fix here create an empty group to be able to display isolated options (when mixed list of optgroup and option) to be diplayed in first position.
Only with Choices library updated that it will allow to use not-in-group options to be displayed at wanted places. For now, it's impossible.
So, yes, this change could be reverted when choices fixed! ;-)
| Labels |
Added:
PR-5.1-dev
Removed: PR-4.4-dev |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-04 12:00:27 |
| Closed_By | ⇒ | LadySolveig |
Thank you for this nice improvement! @cyrezdev And also for testing @fgsw @ChristineWk
Thank all for testing and feedback! ?
Please fix phpcs https://ci.joomla.org/joomla/joomla-cms/73346/1/8