RTC PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomlaweby
joomlaweby
30 Jan 2024

Summary of Changes

Converts the messages administrator module to service provider.

This is my first pull request to Joomla! project :-).

Testing Instructions

  1. Make sure you have administrator component com_messages (Private Messages) and module mod_messages enabled
  2. Make sure you have at least 1 unread message
  3. You should see module output

mod_messages

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomlaweby joomlaweby - open - 30 Jan 2024
avatar joomlaweby joomlaweby - change - 30 Jan 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2024
Category Modules Administration
avatar joomlaweby joomlaweby - change - 30 Jan 2024
Labels Added: PR-5.1-dev
avatar fgsw fgsw - test_item - 3 Feb 2024 - Tested successfully
avatar fgsw
fgsw - comment - 3 Feb 2024

I have tested this item ✅ successfully on 24ba818


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

avatar richard67 richard67 - alter_testresult - 11 Feb 2024 - fgsw: Tested successfully
avatar richard67
richard67 - comment - 11 Feb 2024

@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.

avatar joomlaweby
joomlaweby - comment - 11 Feb 2024

@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.

@richard67 OK, got it. :-)

avatar viocassel viocassel - test_item - 22 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 22 Feb 2024

I have tested this item ✅ successfully on 769c4ab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

avatar richard67 richard67 - change - 22 Feb 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

avatar exlemor
exlemor - comment - 24 Feb 2024

Tested successfully during PBF 2024.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.

avatar LadySolveig LadySolveig - change - 25 Feb 2024
Labels Added: RTC
avatar LadySolveig LadySolveig - change - 27 Feb 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-02-27 00:23:45
Closed_By LadySolveig
avatar LadySolveig LadySolveig - close - 27 Feb 2024
avatar LadySolveig LadySolveig - merge - 27 Feb 2024
avatar LadySolveig
LadySolveig - comment - 27 Feb 2024

Thank you @joomlaweby and also for testing and support @fgsw @viocassel @exlemor @richard67 @sandewt

Add a Comment

Login with GitHub to post a comment