[#42735] - Convert mod_messages to service provider
- Fixed in Code Base
- 27 Feb 2024
- Medium
- Build: 5.1-dev
- # 42735
- Diff
- joomlaweby:mod-messages
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the messages administrator module to service provider.
This is my first pull request to Joomla! project :-).
Testing Instructions
- Make sure you have administrator component com_messages (Private Messages) and module mod_messages enabled
- Make sure you have at least 1 unread message
- You should see module output
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
PR-5.1-dev
|
||
@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.
@joomlaweby No need to update your branch when there are no conflicts shown. Updating the branch in validates the test counter for human test. I've restored the result from @fgsw now so it's counted again.
@richard67 OK, got it. :-)
I have tested this item ✅ successfully on 769c4ab
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.
Tested successfully during PBF 2024.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-27 00:23:45 |
| Closed_By | ⇒ | LadySolveig |
Thank you @joomlaweby and also for testing and support @fgsw @viocassel @exlemor @richard67 @sandewt
I have tested this item ✅ successfully on 24ba818
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42735.